admin: Regenerate protos for admin services#29766
Merged
oleiman merged 1 commit intoredpanda-data:devfrom Mar 6, 2026
Merged
Conversation
Seems like we missed it in 48a4b78 Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR regenerates Python protobuf bindings that were missed in a previous commit (48a4b78). The changes add the GetDatabaseStats RPC to the metastore service, update TLS PEM settings options, and add a docstring to the datalake DescribeCatalogResponse.
Changes:
- Added
GetDatabaseStatsRPC with associated request/response messages (GetDatabaseStatsRequest,GetDatabaseStatsResponse,LsmLevel,LsmFile) to the metastore service protobuf bindings - Updated TLS PEM settings serialized options to include the
iobufannotation onca,key, andcertfields - Added docstring to
DescribeCatalogResponsein the datalake type stubs
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
tests/rptest/clients/admin/proto/redpanda/core/common/v1/tls_pb2.py |
Updated serialized descriptor and field options for TLSPEMSettings to include iobuf annotations |
tests/rptest/clients/admin/proto/redpanda/core/admin/internal/datalake/v1/datalake_pb2.pyi |
Added docstring to DescribeCatalogResponse matching the proto comment |
tests/rptest/clients/admin/proto/redpanda/core/admin/internal/cloud_topics/v1/metastore_pb2_connect.py |
Added GetDatabaseStats methods to sync/async clients, protocol, and WSGI registration |
tests/rptest/clients/admin/proto/redpanda/core/admin/internal/cloud_topics/v1/metastore_pb2.pyi |
Added type stubs for GetDatabaseStatsRequest, GetDatabaseStatsResponse, LsmLevel, LsmFile |
tests/rptest/clients/admin/proto/redpanda/core/admin/internal/cloud_topics/v1/metastore_pb2.py |
Updated serialized descriptor with new messages and service method, adjusted serialized offsets |
Member
Author
|
actually there's datalake stuff in there too. didn't even notice. (just comments. so #29677 had a slightly stale commit) |
piyushredpanda
approved these changes
Mar 6, 2026
oleiman
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems like we missed them in #29737 and #29718 and #29677.
Sorry for the misnomer in the commit message.
Backports Required
Release Notes