shadowing: fix name prefix in Kafka client ID#29783
Merged
bharathv merged 1 commit intoredpanda-data:devfrom Mar 10, 2026
Merged
shadowing: fix name prefix in Kafka client ID#29783bharathv merged 1 commit intoredpanda-data:devfrom
bharathv merged 1 commit intoredpanda-data:devfrom
Conversation
This is user visible in link status, so good to keep it consistent with latest terminology.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the shadow-link admin conversion logic so the Kafka client ID prefix matches current “shadow-link” terminology, keeping link status and related user-facing strings consistent.
Changes:
- Change the generated Kafka
client_idprefix fromcluster-link-toshadow-link-.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
1266
to
+1268
| void set_client_id(cluster_link::model::metadata& md) { | ||
| md.connection.client_id = ssx::sformat( | ||
| "cluster-link-{}-{}", md.name, md.uuid); | ||
| "shadow-link-{}-{}", md.name, md.uuid); |
There was a problem hiding this comment.
This changes the user-visible Kafka client_id prefix, but there isn’t a unit test asserting the exact set_client_id format. Consider adding a small test in the existing shadow_link converter tests to verify the generated client_id starts with shadow-link- and includes the link name/uuid, to prevent accidental regressions back to the old prefix.
Collaborator
CI test resultstest results on build#81542
|
pgellert
approved these changes
Mar 10, 2026
Collaborator
|
/backport v25.3.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is user visible in link status, so good to keep it consistent with latest terminology.
Backports Required
Release Notes