[v25.3.x] cluster/feature_manager: use insert_or_assign for version updates#29880
Merged
pgellert merged 1 commit intoredpanda-data:v25.3.xfrom Mar 19, 2026
Merged
Conversation
emplace is a no-op when the key already exists, so a stale version entry can shadow a newer one queued before the loop drains _updates. This delays feature activation by an extra health monitor tick (~10s) because the controller must wait for the next health collection to re-learn the node's version. (cherry picked from commit 1ea6e4e)
pgellert
requested review from
a team and
nguyen-andrew
and removed request for
a team
Collaborator
CI test resultstest results on build#82003 |
nguyen-andrew
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #29824
The second commit (dt: increase alter_cluster_quotas timeout during upgrade) was
dropped because the
QuotaManagementUtilsmixin andQuotaManagementUpgradeTestit modifies do not exist on v25.3.x.
Fixes #29855