Skip to content

Hotfix reference link #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
takahi-i merged 1 commit into from
Dec 14, 2017
Merged

Hotfix reference link #818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions redpen-core/src/main/java/cc/redpen/parser/markdown/ToFileContentSerializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,6 +408,7 @@ public void visit(RefLinkNode refLinkNode) {
String url = getRefLinkUrl(refLinkNode.referenceKey, linkName);
// FIXME how to handle url, if linkName include period character?
// TODO temporary implementation
if (candidateSentences.size() == 0) { return; }
CandidateSentence lastCandidateSentence =
candidateSentences.get(candidateSentences.size() - 1);
if (StringUtils.isNotEmpty(url)) {
Expand Down
14 changes: 14 additions & 0 deletions redpen-core/src/test/java/cc/redpen/MarkdownParserTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -856,6 +856,20 @@ void testThreeSuccuessiveImageNestedLinkWithJaConf() throws Exception {
}
}

@Test
void testReferenceLink() throws Exception {
String sampleText =
"[![foo](foo)][bar]\n\n" +
"[bar]: bar\n";
Configuration conf = Configuration.builder("ja").build();
try {
createFileContent(sampleText, conf);
} catch (Exception e) {
fail("Exception is not expected.");
}
}


@Test
void testNotExtractNoLabelImage() throws Exception {
String sampleText = "![](https://aimless.jp/blog/images/2016-09-07-001.png)\n";
Expand Down