Throwing an error when no modelName is set in register#231
Merged
haveyaseen merged 1 commit intoredux-orm:masterfrom Sep 27, 2018
Merged
Conversation
Adding tests to expect an error to be thrown
haveyaseen
added
type: Enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the comments in #197 I've added the check in register. I've also added a test to assert that when the modelName isn't set an error is thrown.
First of all, thanks for your contribution! :-)
Please makes sure these boxes are checked before submitting your PR, thank you!
master, feature for latest active branchfeature/x.npm run lintand fix those errors before submitting in order to keep consistent code style.