Merged
Conversation
Currently they're only appended during row creation, updates and deletes are still ignored.
haveyaseen
added
type: Enhancement
Require all accessed foreign key indexes to be equal for memoization. There is still an issue causing extremely long removal times, at least for many-to-many relationships.
…indexes. Allow marking indexes as accessed through Model instance. Use an `index` property in Field objects to determine whether or not to index on columns. This removes the need for the table implementation to know about the ForeignKey class and allows for better extensibility for potential other uses of indexes. Add tests that ensure indexes are updated correctly. Improve comments in memoize function.
Collaborator
Author
|
Many-to-many queries don't fully leverage the foreign key indexes yet: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #78 and #88 and Elijen@d965959 / Elijen@ac7ff12. Actually I didn't notice @Elijen's contributions before writing this so there may be some further improvements to take from them.
Currently the indexes are only appended during row creation, updates and deletes are still ignored.
Selectors will need to be updated as well, to account for the fact that we use indexes to optimize foreign key lookups. Then we can prevent full-table scans for simple queries like
author.books.Didn't perform performance benchmarks yet.