Skip to content

Fix #1340 fix socket subscription #1947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ghirtor wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −0
Open

Fix #1340 fix socket subscription #1947

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/redux-devtools-remote/src/devTools.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,6 +402,9 @@ class DevToolsEnhancer<S, A extends Action<string>, PreloadedState> {
for await (const data of this.socket!.subscribe(channelName)) {
this.handleMessages(data as Message<S, A>);
}
for await (const data of this.socket!.subscribe('sc-' + this.socket!.id)) {
Copy link
Copy Markdown

@dacevedo12 dacevedo12 Feb 11, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this ever run as is? I got the fix working only by allowinig both to run concurrently

void (async () => {
  for await (...)
})();

void (async () => {
  for await (...)
})();

this.handleMessages(data as Message<S, A>);
}
} catch (error) {
console.log(error);
}
Expand Down