Skip to content

v0.8 integration#208

Merged
markerikson merged 5 commits intomasterfrom
v0.8-integration
Oct 15, 2019
Merged

v0.8 integration#208
markerikson merged 5 commits intomasterfrom
v0.8-integration

Conversation

@markerikson
Copy link
Copy Markdown
Collaborator

WIP as we try to make sure everything's in place for 0.8.

phryneas and others added 3 commits September 23, 2019 17:06
* Fix missing name field in type test

* Include provided case reducers in createSlice output

- Added `caseReducers` field to the createSlice return object
- Added test and type test for returned case reducer
- Removed "Enhanced" terminology from types, and replaced with
  "CaseReducerWithPrepare" and "CaseReducerDefinition"
- Restructured logic to only loop over reducer names once, and
  check case reducer definition type once per entry

* Add type tests for correct case reducer export inference

* Rewrite caseReducers types for correct inference of state + action

* Add type test for reducers with prepare callback

* Fix type inference for actions from reducers w/ prepare callbacks

* Clean up type names and usages

* Use a generic State type in ActionForReducer

* Re-switch Slice generics order
@netlify
Copy link
Copy Markdown

netlify bot commented Oct 11, 2019

Deploy preview for redux-starter-kit-docs ready!

Built with commit 555d9b1

https://deploy-preview-208--redux-starter-kit-docs.netlify.com

Krisztiaan and others added 2 commits October 13, 2019 18:03
* Change default createAction payload type to void to make it required

* Fix createAction type tests per review
* Update basic tutorial with createSlice changes

* Update intermediate tutorial with createSlice changes

* Update advanced tutorial with createSlice changes

* Change existing commit links to point to reduxjs org repos
@markerikson
Copy link
Copy Markdown
Collaborator Author

Okay, so far we've got:

  • slice? -> name
  • slice.caseReducers
  • createAction defaulting to void payloads
  • initial tutorial updates

I'd like to tweak a couple bits of the createSlice docs (move name first in the options list, add caseReducers to the output snippet`, etc).

Other than that, this may be close to being ready.

Per mention in #213 , I'm going to have to publish 0.8 before I can rewrite the tutorial commits and update the commit links.

I'd like to have the build changes from #212 too if possible, but not sure how long that work will take, so that can be a later release (0.8.1 or 0.9 or something).

@markerikson markerikson marked this pull request as ready for review October 13, 2019 22:36
@markerikson
Copy link
Copy Markdown
Collaborator Author

Awright, no one's had anything to say. I'm gonna merge this in, put out 0.8, and try to polish up the tutorial repos.

@markerikson markerikson merged commit dd2a81e into master Oct 15, 2019
@markerikson markerikson deleted the v0.8-integration branch October 15, 2019 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants