Use Callable Type Signature for Memoize in createSelectorCreator#465
Closed
micahbales wants to merge 1 commit into
Closed
Use Callable Type Signature for Memoize in createSelectorCreator#465micahbales wants to merge 1 commit into
micahbales wants to merge 1 commit into
Conversation
…ator Addresses issue #20007 by adding a callable type signature for the memoize callback in createSelectorCreator. This avoids a type error when using Lodash Memoize as the first argument in createSelectorCreator
|
Any chance we can revisit this PR ? |
|
It's been a year since this repo has had any updates. Probably it's a dead end.. |
Contributor
|
I think if we were to update these types, it would be best to map them to the returned types as well. |
Contributor
So I pulled this change into #486. I'm not sure what you mean by mapping them to the returned types. Isn't Any updates to this PR can easily be pulled into #486 or we can do the changes directly in #486. Not sure of your preference. |
Contributor
|
Closing since this is now included in #486 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses microsoft/TypeScript#20007 by adding a callable type signature for the memoize callback in createSelectorCreator. This avoids a type error when using Lodash Memoize as the first argument in createSelectorCreator