Add a clearCache method to defaultMemoize output functions#519
Merged
Conversation
This allows correct inference of any fields that the memoize function may attach to its generated output function, such as `selector.memoizedResultFunc.clearCache` with `defaultMemoize`.
Codecov Report
@@ Coverage Diff @@
## master #519 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 101 102 +1
Branches 24 24
=========================================
+ Hits 101 102 +1
|
This was referenced Oct 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
defaultMemoizeto enable clearing bothsingletonCacheandlruCacheclearCachemethod on the generated memoized functioncreateSelectortypes to infer the actual type of thememoizefunction's return value, so thatselector.memoizedResultFunc.clearCache()is correctly inferred and usable