Skip to content

Conversation

@jimbethancourt
Copy link
Collaborator

No description provided.

vojislav.cuk and others added 13 commits July 9, 2023 17:17
extracted html report to a separate module. removed all maven related stuff from html report.
extracted csv report into separate module. removed all maven related stuff rrom csv report
extracted json report to separate module. removed all maven related stuff from json report
removed classes from maven json report after refactor
Created cli application using picocli and packaged it as executable jar
- Moved CLI module to Java 8 for now to prep for Upgrade to Java 11
- Commented out ErrorProne - ErrorProne bug was causing compilation issues
 - Some imports were reorganized by spotless
 - commented out gradle deps in build.gradle in case someone tries to build from IDE
- Updated version of JGit to 6.7.0.202309050840-r in order to address CVE-2023-4759
- Keeping dependency-check commented out since it flags newer version of JGit as vulnerable, even though it's not
- Ran OpenRewrite with configuration
```xml
<plugin>
    <groupId>org.openrewrite.maven</groupId>
    <artifactId>rewrite-maven-plugin</artifactId>
    <version>5.7.1</version>
    <configuration>
        <activeRecipes>
            <recipe>org.openrewrite.java.migrate.Java8toJava11</recipe>
        </activeRecipes>
    </configuration>
    <dependencies>
        <dependency>
            <groupId>org.openrewrite.recipe</groupId>
            <artifactId>rewrite-migrate-java</artifactId>
            <version>2.1.0</version>
        </dependency>
    </dependencies>
</plugin>
```
@ghost
Copy link

ghost commented Oct 2, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@jimbethancourt jimbethancourt merged commit cd1ce5a into main Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants