Conversation
Closed
Contributor
Author
|
Test code: |
Contributor
|
Remove the |
Contributor
Author
It does slow the runtime, but I'm only visualizing inside the |
1cdb989 to
8d9d871
Compare
Alek99
approved these changes
Dec 21, 2022
| export const connect = async (socket, state, setResult, endpoint) => { | ||
| export const connect = async (socket, state, result, setResult, router, endpoint) => { | ||
| // Create the socket. | ||
| socket.current = new WebSocket(endpoint); |
Member
There was a problem hiding this comment.
Will we eventually change this so its on socket per app
Contributor
Author
There was a problem hiding this comment.
I'm not sure tbh, we will need to investigate this.
| Raises: | ||
| TypeError: If the given value is not a valid state. | ||
| """ | ||
| # Handle dicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


super().__getattribute__in functions in the critical path of event processing. It's ugly but it's faster.onopenfor web socket to hydrate the page on initial load.