Conversation
Alek99
requested changes
Dec 22, 2022
| @@ -0,0 +1 @@ | |||
| 0.1.11 No newline at end of file | |||
Member
There was a problem hiding this comment.
What the reason for using a txt file vs having a variable in the constants.py
Member
There was a problem hiding this comment.
Oh wait nvm I get it because if they update pc the web folder could be made from the older one
Contributor
Author
There was a problem hiding this comment.
Yeah I tried the config way but this seemed easier
Alek99
approved these changes
Dec 22, 2022
Member
Alek99
left a comment
Alek99
left a comment
There was a problem hiding this comment.
This makes sense to me nicely done clever with the txt file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pcversion.txtfile in the template - we should update this whenever we change the template.pc initagain.