Use ReconnectingWebSocket instead of vanilla WebSocket#348
Merged
picklelo merged 4 commits intoreflex-dev:mainfrom Jan 26, 2023
Merged
Use ReconnectingWebSocket instead of vanilla WebSocket#348picklelo merged 4 commits intoreflex-dev:mainfrom
picklelo merged 4 commits intoreflex-dev:mainfrom
Conversation
ACucos1
pushed a commit
to ACucos1/rd-pynecone
that referenced
this pull request
Feb 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently Pynecone doesn't handle websocket onclose events. Using reconnecting-websocket handles such events automatically.
Note that this does not 100% solve the issues which arise on mobile devices, especially iPhones which aggressively control network connection to preserve battery.