Add support for toggling color mode ('night/day mode')#382
Merged
Alek99 merged 11 commits intoreflex-dev:mainfrom Jan 30, 2023
Merged
Add support for toggling color mode ('night/day mode')#382Alek99 merged 11 commits intoreflex-dev:mainfrom
Alek99 merged 11 commits intoreflex-dev:mainfrom
Conversation
Member
|
Nice going to test this locally and then review |
Alek99
approved these changes
Jan 30, 2023
Member
Alek99
left a comment
There was a problem hiding this comment.
Very nice just tested and works well!
ACucos1
pushed a commit
to ACucos1/rd-pynecone
that referenced
this pull request
Feb 28, 2023
Co-authored-by: g0ee <0@g0.ee> Co-authored-by: g0ee <adbokat.b.a.s.e@gmail.com>
|
is it possible to change the default colors of the dark/light mode? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for toggling color mode ('night/day mode')
This pull request adds support for toggling Chakra's color modes, including the dark mode.
It is easy to use, using the
pc.toggle_color_mode()helper:No custom styling is necessary to use the dark mode, it is built-into Chakra.
Your night/dat mode preference is stored locally as per the Chakra docs.
I believe this pull request would enhance Pynecone's appeal. Having a dark mode on your site is quickly becoming standard and is desired by many users.
All Submissions:
Type of change
Please delete options that are not relevant.
New Feature Submission:
Changes To Core Features: