Skip to content

Fix custom routes on Windows#389

Merged
picklelo merged 2 commits intomainfrom
nikhil/custom-routes
Jan 30, 2023
Merged

Fix custom routes on Windows#389
picklelo merged 2 commits intomainfrom
nikhil/custom-routes

Conversation

@picklelo
Copy link
Contributor

@picklelo picklelo commented Jan 30, 2023

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

New Feature Submission:

  • Does your submission pass the tests?
  • Have you linted your code locally prior to submission?

Changes To Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

After these steps, you're ready to open a pull request.

a. Give a descriptive title to your PR.

b. Describe your changes.

c. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if such).

@picklelo picklelo linked an issue Jan 30, 2023 that may be closed by this pull request
if route == "":
return constants.INDEX_ROUTE

route = route.strip("/")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently os.path.sep was tripping it up on Windows, had to change it to an explicit "/"

@Alek99 Alek99 self-requested a review January 30, 2023 00:34
@picklelo picklelo merged commit 2b7e2ec into main Jan 30, 2023
@picklelo picklelo deleted the nikhil/custom-routes branch January 30, 2023 00:39
ACucos1 pushed a commit to ACucos1/rd-pynecone that referenced this pull request Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

custom-route can't be found.

2 participants