bug: dialtcp lookup while being behind a proxy only for URL type

[Arcelone]

Describe the bug

Using the container image with docker runtime.

When you configure proxy using docker compose with this section :

environment:
      https_proxy: "http://<user>:<pass>@<IP>:<port>"
      http_proxy: "http://<user>:<pass>@<IP>:<port>"
      no_proxy: "<internal.site>"

The "latest version" section works for github type as well as the icon retrieval, but don't works using the URL type.
In the logs i have this error :

ERROR: latest_version/refresh (httpVersionRefreshUncreated_Latest), Get "https://www.somesite.com": dial tcp: lookup www.somesite.com on 127.0.0.11:53: no such host

Inside the container i can use curl https://www.somesite.com and it works, i do get the HTML.

Expected behavior
that the URL type don't try to do a lookup if proxy is set.

Perhaps I have missed something about the proxy configuration for GO. If so, please feel free to provide me with an explanation.

Desktop (please complete the following information):

• OS: debian 13
• Browser: firefox
• Version: 128.11 esr

[Arcelone]

bumping the issue @JosephKav

[JosephKav]

Very odd that it works for github and not url as the code is the same for them, just different addresses. I don't have experience with proxies inside Docker but I can look into this

[Arcelone]

I’ll continue the investigation next week, and provide more details if I find something.

I really appreciate your tool (UI, UX, and overall simplicity).

Im also surprised that the behavior differs between GitHub and other websites. Normally GO applications follow env variable for proxy.
Is it possible that a custom lookup mechanism is implemented somewhere that doesn’t respect the proxy environment variables?

[Arcelone]

@JosephKav OK, I did some investigating.

What I found is that:
You define a custom Transport here:

Argus/service/latest_version/types/web/query.go

Line 81 in d59a155

customTransport := &http.Transport{}

but you don't add the Proxy: ProxyFromEnvironment. As a result, when you choose to verify the certificate, you use this custom transport without a proxy configuration.

However, if you choose not to verify the certificate, you use the http.DefaultTransport.(*http.Transport).Clone() from here:

Argus/service/latest_version/types/web/query.go

Line 84 in d59a155

customTransport = http.DefaultTransport.(*http.Transport).Clone()

and the DefaultTransport is created with the Proxy: ProxyFromEnvironment, as stated here: https://go.dev/src/net/http/transport.go.

I'm not a Go developer; I've only got a basic understanding of the documentation and the code from the repository. Let me know what you think.

If I'm correct, the fix would be to search for all occurrences of xxxxxxxxx := &http.Transport{} in the repository and change them as follows:

xxxxxxx := &http.Transport{
Proxy: ProxyFromEnvironment,
}

[JosephKav]

Thanks for looking into this, makes it a lot quicker/easier to merge in! All looks accurate. I'll add this in after I merge the current FE-refactor PR

[Arcelone]

Ok, SO I did some more testing tonight.

But I've actually coded things to see if I was correct.
(My last investigation where just, testing the app, debugging networking and reading Argus code + go doc).

I have 2 suggestions :

1st :

// replace this :
customTransport := &http.Transport{}
// by this : 
customTransport := &http.Transport{Proxy: http.ProxyFromEnvironment}

2nd :

// replace this :
customTransport := &http.Transport{}
// by this :
customTransport := http.DefaultTransport.(*http.Transport).Clone()

in this file :
/service/latest_version/types/web/query.go

Why not others file ? :

• Because proxies are manly used in corporate environment, so you'll check the latest version using internet resources going through the proxy. But for the deployed version or webhooks requests will mainly be on internal websites, and if you ask the proxy for internal resources/website it can cause problems. Si it's good to not have every request of the binary going through the proxy.

The ideal situation would be have a switch, exactly the same UI as the Allow Invalid Certs one for example, that say use proxy from env var ? (true|false) for latest version, deployed version, and webhook section.
And implement an if statement that if true populate the Proxy variable of the customTransport with the one from the environment variable using the http.ProxyFromEnvironment function.

Note : the difference between the 2 options are the other value like (timeout, retry etc) that have default value in the DefaultTransport and that have no value when you create the Transport from scratch like in the 1st option. BUT I don't know if it makes differences in the rest of the app, I'm not familiar with GO si I don't know if the customTransport is local to the httpRequest fonction at line 80 of /service/latest_version/types/web/query.go, if there are some default value in the DefaultTransport that need to be modified for the app etc....

[JosephKav]

With your suggestion for a switch on whether to use the proxy. Looking at those source file docs you linked (thanks for linking! transport.go) , it reads that you could add those non-proxied url's to NO_PROXY. I'd rather use that than add another config option (why have multiple places to set the same thing)?

It uses HTTP proxies as directed by the environment variables HTTP_PROXY, HTTPS_PROXY and NO_PROXY

[Arcelone]

Yes the no proxy's variable is here for this. Your right.

I got a bit confused with this.

Basically there is 2 questions.

For this URL :

• Proxy Yes/No -> determined by the environment Variables
• Verification of SSL : determined by the switch in the UI.

Using a proxy don't mean that you don't want to verify certificates.
So you should be able to be in the 4 situations Proxy Yes/no and verify SSL yes/no