bug: Uncaught TypeError: Cannot read properties of undefined (reading 'safeParse')

[mvalois]

Describe the bug
On v0.27.0, after upgrading from v0.26.3, when trying to edit or add a service, the view becomes empty and the JS console throws this error:

Uncaught TypeError: Cannot read properties of undefined (reading 'safeParse')
    at rn (index-DaS4OvdM.js:152:63116)
    at index-DaS4OvdM.js:152:69264
    at Array.reduce (<anonymous>)
    at Mde (index-DaS4OvdM.js:152:69205)
    at yfe (index-DaS4OvdM.js:152:82426)
    at index-DaS4OvdM.js:152:84095
    at Object.JE [as useMemo] (index-DaS4OvdM.js:8:57552)
    at B8.mt.useMemo (index-DaS4OvdM.js:1:8935)
    at bfe (index-DaS4OvdM.js:152:83891)
    at _y (index-DaS4OvdM.js:8:48581)

Tried on Firefox and Chromium.

Expected behavior
I expect the edit windows

Screenshots

Desktop (please complete the following information):

• OS: Linux Ubuntu 22.04
• Browser: Firefox, Chromium
• Version: 145.0.2, 142.0.7444.175

[JosephKav]

Looks like an issue with the Zod setup, sorry about this. Any chance you'd be able to send a redacted version of the config file that's causing this?
You can cut as much out as you want as long as it still errors. It could be service specific, or something in your notify/webhook/defaults

[mvalois]

This crashes :

notify:
    matrix:
        url_fields:
            host: a
            password: a
        params:
            rooms: a

[JosephKav]

This crashes :

notify:
    matrix:
        url_fields:
            host: a
            password: a
        params:
            rooms: a

Oh damn, very basic. I'll look into the cause and get a fix out!

[JosephKav]

Argus/web/ui/react-app/src/utils/api/types/config-edit/notify/form/builder.ts

Lines 389 to 402 in f119217

	const schemaDataMains = Object.entries(mains ?? {}).reduce<
	Record<string, NotifySchemaValues>
	>((acc, [key, value]) => {
	const itemType = value.type;
	const data = applyDefaultsRecursive(value, combinedDefaults[itemType]);
	acc[key] = safeParse({
	data: data,
	fallback: { type: itemType },
	path: `${path} (mains-${key})`,
	schema: notifySchemaMap[itemType],
	});
	return acc;
	}, {});

Looks like it's requiring notify.X to have a type, so it's not handling this case where the name is the type.

I'll update it to use the type, and have that default to the name (if the name is a known type) like I do above for the defaults

Argus/web/ui/react-app/src/utils/api/types/config-edit/notify/form/builder.ts

Lines 374 to 375 in f119217

	const itemType =
	main?.type ?? (isNotifyType(nameLower) ? nameLower : null);

My mistake missing this, sorry 😄

(if you wanted a temporary fix until I get this merged+released, you could manually add in)

notify:
    matrix:
        type: matrix
        url_fields:
            host: a
            password: a
        params:
            rooms: a

[mvalois]

It works! I've added the type manually. Many thanks for the really quick fix!