Skip to content

fix(ui): support notify.<type> with no explicit type field#704

Merged
JosephKav merged 1 commit intomasterfrom
702-bug-uncaught-typeerror-cannot-read-properties-of-undefined-reading-safeparse
Dec 10, 2025
Merged

fix(ui): support notify.<type> with no explicit type field#704
JosephKav merged 1 commit intomasterfrom
702-bug-uncaught-typeerror-cannot-read-properties-of-undefined-reading-safeparse

Conversation

@JosephKav
Copy link
Copy Markdown
Collaborator

Zod wasn't recognising
notify.matrix as type matrix

notify:
    matrix:
        url_fields:
            ...

was requiring

notify:
    matrix:
        type: matrix
        url_fields:
            ...

This makes it fallback to name if type isn't explicitly provided (and checks that name is of a supported type)

@JosephKav JosephKav added the bug Something isn't working label Dec 10, 2025
@JosephKav JosephKav changed the title fix(ui): support notify.x as type when no explicit type fix(ui): support notify.<type> with no explicit type Dec 10, 2025
@JosephKav JosephKav changed the title fix(ui): support notify.<type> with no explicit type fix(ui): support notify.<type> with no explicit type field Dec 10, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.82%. Comparing base (f119217) to head (0be1bd8).
⚠️ Report is 13 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #704   +/-   ##
=======================================
  Coverage   98.82%   98.82%           
=======================================
  Files         132      132           
  Lines        8891     8891           
=======================================
  Hits         8786     8786           
  Misses         80       80           
  Partials       25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JosephKav JosephKav merged commit 6f60f3a into master Dec 10, 2025
7 checks passed
@JosephKav JosephKav deleted the 702-bug-uncaught-typeerror-cannot-read-properties-of-undefined-reading-safeparse branch December 10, 2025 01:04
This was referenced Dec 10, 2025
@JosephKav JosephKav added the javascript Pull requests that update Javascript code label Dec 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Uncaught TypeError: Cannot read properties of undefined (reading 'safeParse')

1 participant