Skip to content

fix: increase response body limit from 10 MiB to 50 MiB in queries #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JosephKav merged 2 commits into from
Jan 28, 2026
Merged

fix: increase response body limit from 10 MiB to 50 MiB in queries #814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
990e7d8
fix: increase response body limit from 10 MiB to 50 MiB in queries
JosephKav Jan 28, 2026
26cb6aa
chore: cleanup duplicated logging
JosephKav Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion service/deployed_version/types/web/query.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ func (l *Lookup) httpRequest(logFrom logutil.LogFrom) ([]byte, error) {
}

// Return the body.
body, err := io.ReadAll(io.LimitReader(resp.Body, 10<<20)) // Limit to 10 MB.
body, err := io.ReadAll(io.LimitReader(resp.Body, 50<<20)) // Limit to 50 MiB.
logutil.Log.Error(err, logFrom, err != nil)
return body, err //nolint:wrapcheck
}
Expand Down
5 changes: 1 addition & 4 deletions service/latest_version/types/github/github.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,11 +89,8 @@ func (l *Lookup) filterGitHubReleases(logFrom logutil.LogFrom) []github_types.Re
func (l *Lookup) checkGitHubReleasesBody(body []byte, logFrom logutil.LogFrom) ([]github_types.Release, error) {
var releases []github_types.Release
if err := json.Unmarshal(body, &releases); err != nil {
logutil.Log.Error(err, logFrom, true)
err = fmt.Errorf("unmarshal of GitHub API data failed\n%w",
return nil, fmt.Errorf("unmarshal of GitHub API data failed\n%w",
err)
logutil.Log.Error(err, logFrom, true)
return nil, err
}

return releases, nil
Expand Down
2 changes: 1 addition & 1 deletion service/latest_version/types/github/query.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ func (l *Lookup) getResponse(req *http.Request, logFrom logutil.LogFrom) (*http.

// Read the response body.
defer resp.Body.Close()
body, err := io.ReadAll(io.LimitReader(resp.Body, 10<<20)) // Limit to 10 MB.
body, err := io.ReadAll(io.LimitReader(resp.Body, 50<<20)) // Limit to 50 MiB.
if err != nil {
logutil.Log.Error(err, logFrom, true)
return nil, nil, err //nolint:wrapcheck
Expand Down
2 changes: 1 addition & 1 deletion service/latest_version/types/web/query.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ func (l *Lookup) httpRequest(logFrom logutil.LogFrom) ([]byte, error) {

// Read the response body.
defer resp.Body.Close()
body, err := io.ReadAll(io.LimitReader(resp.Body, 10<<20)) // Limit to 10 MB.
body, err := io.ReadAll(io.LimitReader(resp.Body, 50<<20)) // Limit to 50 MiB.
logutil.Log.Error(err, logFrom, err != nil)
return body, err //nolint:wrapcheck
}
Expand Down
Loading