fix(react-router): add crossOrigin prop to Links component#14687
fix(react-router): add crossOrigin prop to Links component#14687markdalgleish merged 10 commits intoremix-run:devfrom
Conversation
🦋 Changeset detectedLatest commit: c6d079d The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
|
Hi @joseph0926, @markdalgleish Shouldn't this fix be also applied here? We're trying to migrate from Styled Components to CSS modules, and we're facing an issue where dynamically added css links are not including the Thanks! |
|
I'm not entirely sure, but it does seem like the part you mentioned in your comment is missing. However, it doesn't appear to be just a single instance of |
Description
When using a CDN with CORS headers, CSS files loaded via the
<Links>component can fail due to browser cache behavior.After #14463, React Router appends
#suffix to CSS hrefs for dynamic imports. This causes Vite to make a separate request (since URLs differ), but both requests share the browser cache. If React Router's<link>lackscrossOriginwhile Vite's hascrossOrigin="anonymous", the cached response (without CORS headers) fails Vite's CORS check.Changes
crossOriginprop toLinksPropsinterfacecrossOriginto<link>elements inLinkscomponentImpact
Fixes #14678