Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

[Simplified Chinese] Refine translations to satisfied with new changes#102

Merged
dewil-official merged 7 commits intoremnoteio:mainfrom
lovedebug:main
May 12, 2025
Merged

[Simplified Chinese] Refine translations to satisfied with new changes#102
dewil-official merged 7 commits intoremnoteio:mainfrom
lovedebug:main

Conversation

@lovedebug
Copy link
Contributor

@lovedebug lovedebug commented May 10, 2025

Refine translations due to existed strings changed

Summary by CodeRabbit

  • Style

    • Improved clarity, consistency, and naturalness of Chinese localization across various UI sections, including error messages, dialog prompts, settings, notifications, and labels.
    • Enhanced terminology and readability for flashcard, table, tag, and template-related texts.
    • Added a new label for "录音" (recording).
    • Minor punctuation and formatting adjustments for better user experience.
  • Chores

    • Updated the structure of a help text entry in the English localization file for consistency.

@lovedebug lovedebug requested a review from dewil-official as a code owner May 10, 2025 14:42
@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 10, 2025

Walkthrough

This update refines Chinese localization strings for improved clarity, consistency, and naturalness across various UI sections. Additionally, it changes the structure of the "PROPERTIES_HELP_TEXT" entry in the English localization file from an array to an object, standardizing the JSON format for this help text.

Changes

File(s) Change Summary
cn/all.json Refined, reworded, and standardized Chinese localization strings across UI, dialogs, settings, notifications, and labels; fixed punctuation and formatting; added new label for "录音" (recording). No logic changes.
en/all.json Changed "PROPERTIES_HELP_TEXT" entry from an array to an object with a numeric string key, without altering the text content.

Possibly related PRs

  • Update translations #91: Modifies the structure of the "PROPERTIES_HELP_TEXT" entry in the en/all.json localization file, directly overlapping with this change.
  • Update translations #100: Also alters the JSON structure of the "PROPERTIES_HELP_TEXT" entry, making it directly related.
  • Update translations #94: Adds new Chinese translation keys; related by context as both PRs address Chinese localization files.

Suggested reviewers

  • dewil-official

Poem

A bunny with a brush and pen,
Tidies words again and again.
Labels clearer, prompts refined,
In every string, new clarity we find.
With "录音" now in view,
The UI feels fresh and new!
🐇✨

Tip

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (6)
cn/all.json (6)

89-91: File upload warnings: punctuation and consistency
The translations for caching and local upload warnings are correct. However, the "PDF" snipping warning is missing a terminal “。”—adding it will align with other messages.

Apply this diff:

-      "PDF": "请联系支持人员"
+      "PDF": "请联系支持人员。"

Also applies to: 95-96


218-218: PDF options translations: punctuation & theme names

  • Add a trailing “。” to "SPLIT_PANES_TOOLTIP" for consistency.
  • The theme name "SOLARISED" remains in English—consider translating it or documenting why it’s left unchanged to match UI branding.
-      "SPLIT_PANES_TOOLTIP": "编辑器与 PDF 阅读器分屏显示"
+      "SPLIT_PANES_TOOLTIP": "编辑器与 PDF 阅读器分屏显示。"

Also applies to: 221-221, 223-227


790-791: Refine “PRESS_TO_SAVE” phrasing
The current "Enter 保存" could be more natural as “按 Enter 键保存” to match typical Chinese UX wording.

-        "PRESS_TO_SAVE": "Enter 保存",
+        "PRESS_TO_SAVE": "按 Enter 键保存",

799-801: Nit: placeholder spacing in table creation
Consider adding spaces around {{viewName}} for readability, e.g. "链接到现有 {{viewName}} 源" and "新建一个空白的 {{viewName}} 并关联新标签".

Also applies to: 803-805


812-812: Nit: refine search placeholder wording
“搜索现有标签用于添加” could read more naturally as “搜索现有标签以添加”。


821-821: Nit: add punctuation to template help texts
The help-text entries under "TEMPLATES" would benefit from terminal “。” for consistency with other paragraphs.

Example:

-    "AUTO_APPLY_HELP_TEXT": "此模板将自动应用到其表格中的所有行,或所有带有该模板标签的 Rem",
+    "AUTO_APPLY_HELP_TEXT": "此模板将自动应用到其表格中的所有行,或所有带有该模板标签的 Rem。"

Also applies to: 825-825, 831-831, 832-832

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 94af504 and 157f6a3.

📒 Files selected for processing (2)
  • cn/all.json (22 hunks)
  • en/all.json (1 hunks)
🔇 Additional comments (14)
en/all.json (1)

779-781: Confirm JSON structure change for PROPERTIES_HELP_TEXT
The key PROPERTIES_HELP_TEXT has been converted from an array to an object with a numeric key. Ensure that the UI rendering code now expects this object format and that all other localization files (including Simplified Chinese) mirror this structural update.

cn/all.json (13)

31-32: Approve refined error messages for sharing flow
The updated translations for NO_CONTENT and NO_TITLE are clear, correctly include the {{minimum}} placeholder, and use appropriate punctuation.

Also applies to: 35-36


44-44: Approve dialog prompt translation
The Chinese translation for "DELETE_ALSO_UNSHARE" is concise and matches the tone of other confirmation dialogs.


63-63: Approve deprecation warning translation
The updated wording for "DEPRECATION_WARNING" accurately conveys the deprecation and provides the recommended action.


101-101: Approve translation info settings wording
The phrasing clearly explains the mix of English and target language and points users to the tutorial and editor links.


113-114: Approve empty-state notification messages
The updated "EMPTY_STATE_MESSAGE" and "EMPTY_STATE_TITLE" maintain clarity and consistent punctuation.


190-190: Approve PDF annotation warning
The "NO_TEXT_IN_PDF_WARN" translation is clear and consistent with other PDF warnings.


338-338: Approve invite & toast translations
The new messages for inviting friends and toast notifications are accurate, placeholders are correct, and punctuation is consistent.

Also applies to: 342-342, 347-348


374-374: Approve date/time settings translations
Custom date and time format descriptions and the week-start setting read naturally and use proper Chinese punctuation.

Also applies to: 378-378, 382-383


389-390: Approve editor feature translations
All newly added descriptions and titles for search-creation and spellcheck features are well-phrased and remain consistent with existing localization tone.

Also applies to: 393-393, 396-397, 399-399, 403-404, 409-410, 413-414


419-420: Approve editor interface translations
Updated labels for zooming, scaling, single-click, and animations are clear and align with UI terminology.

Also applies to: 428-429, 432-433, 436-437


427-427: Approve flashcards settings translations
All descriptions for daily targets, learn-ahead limits, leech thresholds, new card limits, reset actions, and TTS settings are accurate and use consistent terminology.

Also applies to: 431-431, 459-459, 463-463, 467-468, 471-472, 475-477, 479-480, 484-485, 492-493


503-504: Approve flashcard clustering translations
Descriptions and titles for document, hierarchy, reference, and tag clustering are correctly translated and concise.

Also applies to: 507-508, 510-511, 513-514


745-748: Approve table menus and configuration translations
All filter labels, table-view titles, cell-height options, and view actions are translated clearly, with appropriate punctuation and consistent naming.

Also applies to: 756-756, 759-763, 764-765, 767-770, 771-773, 775-775, 784-785

@dewil-official dewil-official merged commit fb0eef9 into remnoteio:main May 12, 2025
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants