Skip to content

Continue Ktor PR by @zavidnyi#472

Open
nomisRev wants to merge 11 commits intorenaissance-benchmarks:masterfrom
nomisRev:fix-zavidnyi-pr
Open

Continue Ktor PR by @zavidnyi#472
nomisRev wants to merge 11 commits intorenaissance-benchmarks:masterfrom
nomisRev:fix-zavidnyi-pr

Conversation

@nomisRev
Copy link
Copy Markdown

This PR continues the open PR from @zavidnyi

@nomisRev
Copy link
Copy Markdown
Author

nomisRev commented May 2, 2025

Hey @lbulej, could you approve the workflow to run? Everything seems to be building correctly for me locally, not sure if I missed some checks.

@nomisRev nomisRev force-pushed the fix-zavidnyi-pr branch from 6921796 to 48959b7 Compare May 6, 2025 10:56
@nomisRev
Copy link
Copy Markdown
Author

nomisRev commented May 6, 2025

@lbulej could you retrigger? Benchmarks are successfully running for me locally 👍 Only changes on top of @zavidnyi work is changing to JetBrains SBT Kotlin plugin, and bump Kotlin to 2.x.x.

@nomisRev
Copy link
Copy Markdown
Author

nomisRev commented May 6, 2025

All of these GitHub Action steps run for me locally on MacOs 😕

      - name: Run the suite
        shell: bash
        run: tools/ci/bench-base.sh

      - name: Run the suite in standalone mode
        shell: bash
        run: tools/ci/bench-standalone.sh

      - name: Run the suite with JMH
        shell: bash
        run: tools/ci/bench-jmh.sh

Also strange that tools/ci/bench-base.sh works on Linux & Windows but not macOS.
Any ideas?

@vhotspur
Copy link
Copy Markdown
Member

vhotspur commented May 6, 2025

Hello, @nomisRev, I have retriggered the workflow but I wonder why aren't you using your own fork to run the workflow there? I believe once you enable GitHub actions for your repository it should run there as well and it would be much simpler for you to debug it with full access instead of relying on us for running it for you...

@nomisRev
Copy link
Copy Markdown
Author

nomisRev commented May 6, 2025

@vhotspur I will from now on, but I didn't expect so many strange issues. I.e. #472 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants