Continue Ktor PR by @zavidnyi#472
Open
nomisRev wants to merge 11 commits intorenaissance-benchmarks:masterfrom
Open
Continue Ktor PR by @zavidnyi#472nomisRev wants to merge 11 commits intorenaissance-benchmarks:masterfrom
nomisRev wants to merge 11 commits intorenaissance-benchmarks:masterfrom
Conversation
Kotlin plugin for SBT was added. All dependencies specified
…ue to the conflicts
Author
|
Hey @lbulej, could you approve the workflow to run? Everything seems to be building correctly for me locally, not sure if I missed some checks. |
Author
Author
|
All of these GitHub Action steps run for me locally on MacOs 😕 - name: Run the suite
shell: bash
run: tools/ci/bench-base.sh
- name: Run the suite in standalone mode
shell: bash
run: tools/ci/bench-standalone.sh
- name: Run the suite with JMH
shell: bash
run: tools/ci/bench-jmh.shAlso strange that |
Member
|
Hello, @nomisRev, I have retriggered the workflow but I wonder why aren't you using your own fork to run the workflow there? I believe once you enable GitHub actions for your repository it should run there as well and it would be much simpler for you to debug it with full access instead of relying on us for running it for you... |
Author
|
@vhotspur I will from now on, but I didn't expect so many strange issues. I.e. #472 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR continues the open PR from @zavidnyi