Skip to content

Document issues with finagle-chirper on large machines in README.md#499

Merged
lbulej merged 2 commits intorenaissance-benchmarks:masterfrom
simonis:patch-1
Feb 23, 2026
Merged

Document issues with finagle-chirper on large machines in README.md#499
lbulej merged 2 commits intorenaissance-benchmarks:masterfrom
simonis:patch-1

Conversation

@simonis
Copy link
Copy Markdown
Contributor

@simonis simonis commented Feb 16, 2026

No description provided.

@lbulej
Copy link
Copy Markdown
Member

lbulej commented Feb 16, 2026

Thanks for the documentation update @simonis. I was about to merge it, but the README.md file is generated by the MarkdownGenerator utility class and the CI checks that the actual README.md is identical to what would be generated.

Could you please apply the attached patch to this PR's branch in your repo? It will move your change to the right place to make our CI happy :-)

0001-Move-the-documentation-update-to-MarkdownGenerator.patch

@simonis
Copy link
Copy Markdown
Contributor Author

simonis commented Feb 16, 2026

Sure, and thanks for the patch @lbulej . I saw the CI failure but was a little confused and had not started to look into the root cause of it. Hope now everything will work.

@lbulej lbulej changed the title Document issues with finagle-chirpher on large machines in README.md Document issues with finagle-chirper on large machines in README.md Feb 23, 2026
Copy link
Copy Markdown
Member

@lbulej lbulej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@lbulej lbulej merged commit 283fa91 into renaissance-benchmarks:master Feb 23, 2026
90 of 100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants