Refactor InlineNoteElement to use attributeChangedCallback pattern#31
Open
renoirb wants to merge 1 commit into
Open
Refactor InlineNoteElement to use attributeChangedCallback pattern#31renoirb wants to merge 1 commit into
renoirb wants to merge 1 commit into
Conversation
4704ca0 to
1fd5752
Compare
…nd allow changing attributes
1fd5752 to
e561125
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of train #33
Changes
InlineNoteElementto properly implement theattributeChangedCallbacklifecycle methodATTRIBUTESstructure for attribute managementTechnical Details
static get observedAttributes()innerHTMLapproach with template cloning, which is more efficient#renderContent()methodBenefits
Testing Notes
This PR is part of our ongoing effort to standardize component patterns and improve performance across our custom element library.