Merged
Conversation
arein
reviewed
Mar 6, 2025
Contributor
arein
left a comment
arein
left a comment
There was a problem hiding this comment.
Do we need to add some rate limit for the internal logic here? i.e. it only calls this max every 10 seconds now matter how often it's triggered?
Contributor
tomiir
reviewed
May 6, 2025
tomiir
approved these changes
May 6, 2025
0xmkh
approved these changes
May 6, 2025
…t into fix/expose-fetch-balance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The balance in our account button doesn't update after a transaction has happened. This is because we don't have control when a transaction outside AppKit is happening. We tried to find a solution with querying for pending transactions. This resulted in clients exceeding their quota.
This PR exposes the
fetchBalancemethod. Apps can call this after a transaction happened in their app. This will update the correct balance in AppKit.Type of change
Associated Issues
For Linear issues: Closes APKT-1777
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist