chore: disable request permissions btn when permissions capability is not supported#4026
Merged
chore: disable request permissions btn when permissions capability is not supported#4026
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
12 Skipped Deployments
|
Contributor
|
Contributor
Coverage Report
File CoverageNo changed files found. |
tomiir
reviewed
Mar 17, 2025
Comment on lines
+24
to
+26
| const isSmartAccount = accountType === 'smartAccount' | ||
| const isEmailAllowed = Boolean(user?.email?.includes('+smart-sessions@')) | ||
| const isSupported = isSmartSessionSupported() && isSmartAccount && isEmailAllowed |
Collaborator
There was a problem hiding this comment.
shouldn't we be doing something like
const { capabilities } = useCapabilities()
and capabilities.permissions, capabilities.sendCalls etc to enable disable the buttons?
KannuSingh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Disable request permission btn if not smart account and whitelisted email
Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist