Skip to content

fix: do not subscribe in wagmi contructor and do it in construct#4264

Merged
tomiir merged 7 commits intomainfrom
fix/wagmi-subcriptions
May 8, 2025
Merged

fix: do not subscribe in wagmi contructor and do it in construct#4264
tomiir merged 7 commits intomainfrom
fix/wagmi-subcriptions

Conversation

@tomiir
Copy link
Copy Markdown
Collaborator

@tomiir tomiir commented Apr 23, 2025

Description

  • Sets up Wagmi subscriptions in construct instead of constructor

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 23, 2025

⚠️ No Changeset found

Latest commit: a004dbf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2025 9:04am
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2025 9:04am
11 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-ep ⬜️ Ignored (Inspect) May 8, 2025 9:04am
appkit-basic-example ⬜️ Ignored (Inspect) May 8, 2025 9:04am
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) May 8, 2025 9:04am
appkit-basic-up-example ⬜️ Ignored (Inspect) May 8, 2025 9:04am
appkit-ethers5-bera ⬜️ Ignored (Inspect) May 8, 2025 9:04am
appkit-nansen-demo ⬜️ Ignored (Inspect) May 8, 2025 9:04am
appkit-vue-solana ⬜️ Ignored (Inspect) May 8, 2025 9:04am
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) May 8, 2025 9:04am
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) May 8, 2025 9:04am
next-wagmi-solana-bitcoin-example ⬜️ Ignored (Inspect) May 8, 2025 9:04am
vue-wagmi-example ⬜️ Ignored (Inspect) May 8, 2025 9:04am

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 23, 2025

Warnings
⚠️ File packages/adapters/wagmi/src/client.ts contains a KEY or SECRET
⚠️ File packages/appkit/src/client/appkit-base-client.ts contains a KEY or SECRET

Generated by 🚫 dangerJS against a004dbf

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 23, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 75.93% 26364 / 34720
🔵 Statements 75.93% 26364 / 34720
🔵 Functions 67.5% 2229 / 3302
🔵 Branches 83.68% 5213 / 6229
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/adapters/wagmi/src/client.ts 72.88% 63.88% 76.47% 72.88% 105-136, 185-186, 228-232, 257-258, 312-313, 395-396, 424, 440-455, 465-466, 487-488, 492-493, 499-506, 524-535, 544-545, 556-557, 578-580, 594-595, 617-618, 626-627, 632-633, 637-642, 649-650, 658-659, 664-665, 674-675, 683-684, 689-690, 696-718, 721-737
packages/appkit/src/adapters/ChainAdapterBlueprint.ts 90.98% 97.05% 76.47% 90.98% 139-140, 163-167, 173-176
packages/appkit/src/client/appkit-base-client.ts 74.91% 88.31% 77.55% 74.91% 163, 215-216, 218-219, 224-225, 303-304, 340-346, 380-381, 402-408, 411-412, 428-429, 462-466, 479-493, 518-524, 528-540, 543-545, 548-550, 553-555, 558-560, 563-569, 572-574, 577-583, 599-611, 617-650, 653-663, 715-716, 722, 733-747, 753-760, 773-777, 818, 860-864, 870-871, 883, 906-911, 982, 986-987, 993, 1014-1015, 1025, 1027-1043, 1048, 1087-1088, 1101-1112, 1144-1151, 1197-1201, 1230-1233, 1237, 1253-1263, 1285-1296, 1325-1326, 1332-1358, 1514-1515, 1547-1548, 1551-1552, 1567-1570, 1573-1574, 1594-1595, 1598-1599, 1621-1622, 1636, 1644, 1647, 1651, 1656-1675, 1678-1687, 1702-1703, 1746-1749, 1752-1753, 1841-1842, 1845-1848, 1851-1852, 1855-1856, 1859-1860, 1863-1864, 1867-1871, 1880-1889, 1898-1909, 1292, 1658-1679
Generated in workflow #11664 for commit a004dbf by the Vitest Coverage Report Action

@tomiir tomiir enabled auto-merge May 8, 2025 10:14
@tomiir tomiir added this pull request to the merge queue May 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 8, 2025
@tomiir tomiir added this pull request to the merge queue May 8, 2025
Merged via the queue into main with commit d265eb2 May 8, 2025
38 checks passed
@tomiir tomiir deleted the fix/wagmi-subcriptions branch May 8, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants