Skip to content

fix: remove mobile wallets without a mobile_link from the all wallets list#4300

Merged
tomiir merged 8 commits intomainfrom
fix/solflare-not-appearing
May 6, 2025
Merged

fix: remove mobile wallets without a mobile_link from the all wallets list#4300
tomiir merged 8 commits intomainfrom
fix/solflare-not-appearing

Conversation

@tomiir
Copy link
Copy Markdown
Collaborator

@tomiir tomiir commented May 5, 2025

Description

  • Do not list wallets that do not have a mobile_link on mobile environments
  • Adds exception for Coinbase and Phantom Solana which have special redirect mechanisms

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

Partially closes APKT-2789

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@linear
Copy link
Copy Markdown

linear bot commented May 5, 2025

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented May 5, 2025

🦋 Changeset detected

Latest commit: fc98648

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 21 packages
Name Type
@reown/appkit-controllers Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-common Patch
@reown/appkit-core Patch
@reown/appkit-experimental Patch
@reown/appkit-pay Patch
@reown/appkit-polyfills Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch
@reown/appkit-wallet-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented May 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 8:14am
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 8:14am
11 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-ep ⬜️ Ignored (Inspect) May 6, 2025 8:14am
appkit-basic-example ⬜️ Ignored (Inspect) May 6, 2025 8:14am
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) May 6, 2025 8:14am
appkit-basic-up-example ⬜️ Ignored (Inspect) May 6, 2025 8:14am
appkit-ethers5-bera ⬜️ Ignored (Inspect) May 6, 2025 8:14am
appkit-nansen-demo ⬜️ Ignored (Inspect) May 6, 2025 8:14am
appkit-vue-solana ⬜️ Ignored (Inspect) May 6, 2025 8:14am
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) May 6, 2025 8:14am
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) May 6, 2025 8:14am
next-wagmi-solana-bitcoin-example ⬜️ Ignored (Inspect) May 6, 2025 8:14am
vue-wagmi-example ⬜️ Ignored (Inspect) May 6, 2025 8:14am

Comment thread packages/controllers/package.json Outdated
Comment thread packages/controllers/src/controllers/ApiController.ts Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 5, 2025

Warnings
⚠️ File packages/controllers/src/controllers/ApiController.ts contains a KEY or SECRET

Generated by 🚫 dangerJS against fc98648

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 5, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 75.94% 26353 / 34698
🔵 Statements 75.94% 26353 / 34698
🔵 Functions 67.49% 2228 / 3301
🔵 Branches 83.71% 5213 / 6227
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/controllers/src/controllers/ApiController.ts 94.69% 92.17% 86.79% 94.69% 104-105, 193, 200-201, 388-396, 423, 437, 441, 445
packages/scaffold-ui/src/views/w3m-connecting-wc-view/index.ts 67.44% 66.66% 70% 67.44% 49, 62-63, 72, 80-89, 101-102, 116-117, 125-126, 137, 141-144, 149, 153, 170, 174-188
Generated in workflow #11574 for commit fc98648 by the Vitest Coverage Report Action

Comment thread packages/controllers/src/controllers/ApiController.ts
Comment thread packages/controllers/src/controllers/ApiController.ts Outdated
Co-authored-by: Derek <alexanderderekrein@gmail.com>
@tomiir tomiir added this pull request to the merge queue May 6, 2025
@tomiir tomiir removed this pull request from the merge queue due to a manual request May 6, 2025
@tomiir tomiir merged commit b932466 into main May 6, 2025
38 checks passed
@tomiir tomiir deleted the fix/solflare-not-appearing branch May 6, 2025 08:41
@github-actions github-actions bot mentioned this pull request May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants