Skip to content

fix: try/catch getSupportedNetworks #4303

Merged
tomiir merged 3 commits intomainfrom
tomas/apkt-2328-bug-unhandled-promise-rejection-on-getsupportednetworks
May 6, 2025
Merged

fix: try/catch getSupportedNetworks #4303
tomiir merged 3 commits intomainfrom
tomas/apkt-2328-bug-unhandled-promise-rejection-on-getsupportednetworks

Conversation

@tomiir
Copy link
Copy Markdown
Collaborator

@tomiir tomiir commented May 5, 2025

Description

  • Adds try/catch block on getSupportedNetworks to prevent error from bubbling up

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

Closes APKT-2328

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented May 5, 2025

🦋 Changeset detected

Latest commit: 5bc89f5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 21 packages
Name Type
@reown/appkit-controllers Patch
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-common Patch
@reown/appkit-core Patch
@reown/appkit-experimental Patch
@reown/appkit-pay Patch
@reown/appkit-polyfills Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch
@reown/appkit-wallet-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@linear
Copy link
Copy Markdown

linear bot commented May 5, 2025

@vercel
Copy link
Copy Markdown

vercel bot commented May 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2025 6:33pm
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2025 6:33pm
11 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-ep ⬜️ Ignored (Inspect) May 5, 2025 6:33pm
appkit-basic-example ⬜️ Ignored (Inspect) May 5, 2025 6:33pm
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) May 5, 2025 6:33pm
appkit-basic-up-example ⬜️ Ignored (Inspect) May 5, 2025 6:33pm
appkit-ethers5-bera ⬜️ Ignored (Inspect) May 5, 2025 6:33pm
appkit-nansen-demo ⬜️ Ignored (Inspect) May 5, 2025 6:33pm
appkit-vue-solana ⬜️ Ignored (Inspect) May 5, 2025 6:33pm
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) May 5, 2025 6:33pm
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) May 5, 2025 6:33pm
next-wagmi-solana-bitcoin-example ⬜️ Ignored (Inspect) May 5, 2025 6:33pm
vue-wagmi-example ⬜️ Ignored (Inspect) May 5, 2025 6:33pm

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 5, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 75.93% 26336 / 34681
🔵 Statements 75.93% 26336 / 34681
🔵 Functions 67.47% 2226 / 3299
🔵 Branches 83.69% 5201 / 6214
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/controllers/src/controllers/BlockchainApiController.ts 39.85% 66.66% 27.65% 39.85% 173-174, 187-189, 209-210, 216, 231-254, 258-277, 281-293, 297-314, 322-323, 338-357, 361-390, 394-419, 433-456, 460-470, 474-487, 491-501, 505-523, 527-555, 559-577, 581-618, 622-631, 634-650, 276-313, 356-649
Generated in workflow #11561 for commit 5bc89f5 by the Vitest Coverage Report Action

@tomiir tomiir merged commit 33b3693 into main May 6, 2025
38 checks passed
@tomiir tomiir deleted the tomas/apkt-2328-bug-unhandled-promise-rejection-on-getsupportednetworks branch May 6, 2025 06:22
@github-actions github-actions bot mentioned this pull request May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants