Skip to content

chore: update open pay interface#4316

Merged
lukaisailovic merged 2 commits intomainfrom
chore/pay-interface
May 7, 2025
Merged

chore: update open pay interface#4316
lukaisailovic merged 2 commits intomainfrom
chore/pay-interface

Conversation

@lukaisailovic
Copy link
Copy Markdown
Collaborator

Description

Change the pay interface to have 3 separate fields: recipient, amount and paymentAsset

await open({
      recipient: paymentDetails.recipient,
      amount: paymentDetails.amount,
      paymentAsset: {
        network: paymentDetails.network as `eip155:${string}`,
        asset: paymentDetails.asset as AddressOrNative,
        metadata: paymentDetails.metadata
      }
    })

This allows us in future to export a list of paymentAssets if clients prefer to use it in that way

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@lukaisailovic lukaisailovic self-assigned this May 7, 2025
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented May 7, 2025

⚠️ No Changeset found

Latest commit: 1fbda47

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented May 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2025 1:28pm
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2025 1:28pm
11 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-ep ⬜️ Ignored (Inspect) May 7, 2025 1:28pm
appkit-basic-example ⬜️ Ignored (Inspect) May 7, 2025 1:28pm
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) May 7, 2025 1:28pm
appkit-basic-up-example ⬜️ Ignored (Inspect) May 7, 2025 1:28pm
appkit-ethers5-bera ⬜️ Ignored (Inspect) May 7, 2025 1:28pm
appkit-nansen-demo ⬜️ Ignored (Inspect) May 7, 2025 1:28pm
appkit-vue-solana ⬜️ Ignored (Inspect) May 7, 2025 1:28pm
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) May 7, 2025 1:28pm
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) May 7, 2025 1:28pm
next-wagmi-solana-bitcoin-example ⬜️ Ignored (Inspect) May 7, 2025 1:28pm
vue-wagmi-example ⬜️ Ignored (Inspect) May 7, 2025 1:28pm

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 7, 2025

Warnings
⚠️ File apps/laboratory/src/components/AppKitPay.tsx contains a KEY or SECRET
⚠️ File packages/pay/src/controllers/PayController.ts contains a KEY or SECRET
⚠️ File packages/pay/src/ui/w3m-pay-view/index.ts contains a KEY or SECRET
⚠️ File packages/pay/tests/ui/w3m-pay-view.test.ts contains a KEY or SECRET

Generated by 🚫 dangerJS against 1fbda47

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 7, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 75.93% 26365 / 34719
🔵 Statements 75.93% 26365 / 34719
🔵 Functions 67.49% 2228 / 3301
🔵 Branches 83.7% 5215 / 6230
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/pay/src/controllers/PayController.ts 86.16% 86.15% 78.94% 86.16% 89-90, 136-137, 219-220, 225-226, 231-234, 243-244, 249-250, 254-255, 259-260, 263-264, 320-321, 401-408, 411-424
packages/pay/src/ui/w3m-pay-view/index.ts 94.57% 86.11% 100% 94.57% 216-220, 222-223
packages/pay/src/utils/PaymentUtil.ts 86.81% 85.71% 100% 86.81% 76-80, 84-85, 110-114
Generated in workflow #11618 for commit 1fbda47 by the Vitest Coverage Report Action

@lukaisailovic lukaisailovic added this pull request to the merge queue May 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 7, 2025
@lukaisailovic lukaisailovic merged commit f831401 into main May 7, 2025
38 checks passed
@lukaisailovic lukaisailovic deleted the chore/pay-interface branch May 7, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants