Conversation
🦋 Changeset detectedLatest commit: 52abad0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 23 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
10 Skipped Deployments
|
packages/siwx/tests/ui/w3m-data-capture-otp-confirm-view.test.ts
Outdated
Show resolved
Hide resolved
packages/siwx/src/ui/w3m-data-capture-otp-confirm-view/index.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Bug: Async Method Call Without Error Handling
The firstUpdated() method calls the async this.onSubmit() without awaiting it or handling potential errors. This can lead to unhandled promise rejections if onSubmit() throws an error, such as when the account is not connected.
packages/siwx/src/ui/w3m-data-capture-view/index.ts#L46-L54
appkit/packages/siwx/src/ui/w3m-data-capture-view/index.ts
Lines 46 to 54 in 52abad0
Was this report helpful? Give feedback by reacting with 👍 or 👎
Description
Main Purpose: Adds optional email collection functionality to the authentication flow with OTP verification.
Key Changes:
New UI Components:
Router & Navigation:
DataCaptureandDataCaptureOtpConfirmstates to the routerConfiguration & Feature Flags:
emailCapturefeature flag to configurationenableCloudAuthAccountoption to frame providerStorage & Data Management:
@appkit/recent_emailsstorage key for persisting recent emailsTesting & Quality:
Dependencies:
@reown/appkit-siwxas optional dependencyImpact: This feature allows applications to optionally collect user emails during the authentication process, with proper OTP verification and user-friendly UI components for email management.
Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist