Skip to content

Fix: export types to enable proper type inference from useAppKit function#4497

Merged
arein merged 8 commits intoreown-com:mainfrom
venturars:APKT-3050/fix-inference-type-error
Jul 17, 2025
Merged

Fix: export types to enable proper type inference from useAppKit function#4497
arein merged 8 commits intoreown-com:mainfrom
venturars:APKT-3050/fix-inference-type-error

Conversation

@venturars
Copy link
Copy Markdown
Contributor

@venturars venturars commented Jun 11, 2025

Description

Export types AppKitBaseClient, OpenOptions, and Views to enable proper type inference when using useAppKit function.

https://imgur.com/a/s3b94Fy

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-3050
For GH issues: closes #4496

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jun 11, 2025

⚠️ No Changeset found

Latest commit: fcc1570

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Jun 11, 2025

@venturars is attempting to deploy a commit to the Reown Team on Vercel.

A member of the Team first needs to authorize it.

@venturars venturars changed the title Fix: export types to enable proper type inference from the useAppKit function Fix: export types to enable proper type inference from useAppKit function Jun 11, 2025
@arein arein requested a review from svenvoskamp June 11, 2025 14:43
Copy link
Copy Markdown
Contributor

@enesozturk enesozturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a question

@venturars
Copy link
Copy Markdown
Contributor Author

@enesozturk, I’ve committed the recommended changes

@venturars venturars requested a review from enesozturk June 25, 2025 15:01
@vercel
Copy link
Copy Markdown

vercel bot commented Jul 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-basic-html ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2025 3:21pm
appkit-gallery ✅ Ready (Inspect) Visit Preview Jul 17, 2025 3:21pm
appkit-laboratory ✅ Ready (Inspect) Visit Preview Jul 17, 2025 3:21pm

@enesozturk
Copy link
Copy Markdown
Contributor

@venturars Looks good! Can you push changeset file so you'd be credited in the next release? 🙏🏽 To do so:

pnpm changeset (in the root)
  1. Select all packages
  2. Skip major
  3. Skip minor
  4. Give description: "Exports type definitions of Base class for better TS support when using hooks"

@arein arein enabled auto-merge July 17, 2025 14:48
@arein arein disabled auto-merge July 17, 2025 14:48
@arein arein merged commit cce9775 into reown-com:main Jul 17, 2025
13 of 27 checks passed
@venturars
Copy link
Copy Markdown
Contributor Author

@enesozturk hey friend, did you already push the changeset file, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] Updating from version 1.6.8 to 1.7.8 causes a type inference error from the useAppKit function

5 participants