Skip to content

chore: add bitcoin wallet impl for reown extension, add e2e tests#4525

Merged
enesozturk merged 23 commits intomainfrom
enes/apkt-2667-add-extension-wallet-test-coverage-for-bitcoin-adapter
Jun 25, 2025
Merged

chore: add bitcoin wallet impl for reown extension, add e2e tests#4525
enesozturk merged 23 commits intomainfrom
enes/apkt-2667-add-extension-wallet-test-coverage-for-bitcoin-adapter

Conversation

@enesozturk
Copy link
Copy Markdown
Contributor

@enesozturk enesozturk commented Jun 18, 2025

Description

Implements BitcoinProvider for Reown browser extension to use Bitcoin extension wallet in our E2E testing suite.

This requires some update on Bitcoin adapter's WalletStandardConnector so switchNetwork implementation can be overridden with custom connector implementation.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@linear
Copy link
Copy Markdown

linear bot commented Jun 18, 2025

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jun 18, 2025

🦋 Changeset detected

Latest commit: 68e2b80

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages
Name Type
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-codemod Patch
@reown/appkit-common Patch
@reown/appkit-controllers Patch
@reown/appkit-core Patch
@reown/appkit-experimental Patch
@reown/appkit-pay Patch
@reown/appkit-polyfills Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-testing Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch
@reown/appkit-wallet-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Jun 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-basic-html ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2025 8:49am
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2025 8:49am
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2025 8:49am
10 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-example ⬜️ Ignored (Inspect) Jun 25, 2025 8:49am
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) Jun 25, 2025 8:49am
appkit-basic-up-example ⬜️ Ignored (Inspect) Visit Preview Jun 25, 2025 8:49am
appkit-ethers5-bera ⬜️ Ignored (Inspect) Jun 25, 2025 8:49am
appkit-nansen-demo ⬜️ Ignored (Inspect) Jun 25, 2025 8:49am
appkit-vue-solana ⬜️ Ignored (Inspect) Jun 25, 2025 8:49am
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Jun 25, 2025 8:49am
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) Jun 25, 2025 8:49am
next-wagmi-solana-bitcoin-example ⬜️ Ignored (Inspect) Jun 25, 2025 8:49am
vue-wagmi-example ⬜️ Ignored (Inspect) Jun 25, 2025 8:49am

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 18, 2025

Warnings
⚠️

🔑 Potential High‑entropy string detected in apps/browser-extension/src/core/BitcoinProvider.ts (line 14): 000000000019d6689c08...

⚠️

🔑 Potential High‑entropy string detected in apps/browser-extension/src/core/BitcoinProvider.ts (line 15): 000000000933ea01ad0e...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 3): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 3): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️ Testing spec changed

Generated by 🚫 dangerJS against 68e2b80

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 18, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 77.68% 30575 / 39358
🔵 Statements 77.68% 30575 / 39358
🔵 Functions 68.53% 2525 / 3684
🔵 Branches 84.35% 6346 / 7523
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/adapters/bitcoin/src/connectors/WalletStandardConnector.ts 93.9% 100% 88.23% 93.9% 45-46, 213-225
packages/adapters/bitcoin/src/utils/BitcoinApi.ts 100% 100% 100% 100%
Generated in workflow #12940 for commit 68e2b80 by the Vitest Coverage Report Action

@enesozturk enesozturk enabled auto-merge June 25, 2025 09:16
@enesozturk enesozturk added this pull request to the merge queue Jun 25, 2025
Merged via the queue into main with commit f17c13a Jun 25, 2025
58 of 59 checks passed
@enesozturk enesozturk deleted the enes/apkt-2667-add-extension-wallet-test-coverage-for-bitcoin-adapter branch June 25, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants