fix: reduce calling auth connect to once when switching account type#4586
fix: reduce calling auth connect to once when switching account type#4586svenvoskamp merged 38 commits intomainfrom
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
10 Skipped Deployments
|
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
…appkit into fix/connectioncontroller-auth
There was a problem hiding this comment.
Bug: Auth Connector Fails Without Address
The handleActiveConnection method now incorrectly returns undefined for auth connectors when the address parameter is falsy. The refactored logic skips the connectExternal call for auth connectors, which previously provided a fallback mechanism to obtain a valid address, thus breaking the expected connection flow.
packages/controllers/src/controllers/ConnectionController.ts#L448-L467
appkit/packages/controllers/src/controllers/ConnectionController.ts
Lines 448 to 467 in de6a59b
Was this report helpful? Give feedback by reacting with 👍 or 👎
Description
Please include a brief summary of the change.
Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist