fix: reconnectExternal will go through SIWXUtil on Ethers client#4587
fix: reconnectExternal will go through SIWXUtil on Ethers client#4587
reconnectExternal will go through SIWXUtil on Ethers client#4587Conversation
…appkit into fix/connectioncontroller-auth
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
10 Skipped Deployments
|
reconnectExternal will go through SIWXUtil on Ethers client
|
There was a problem hiding this comment.
Bug: Reconnect Method Omitting SocialUri Parameter
The reconnect method in packages/adapters/ethers5/src/client.ts and packages/adapters/ethers/src/client.ts extracts only id and chainId from AdapterBlueprint.ConnectParams. It incorrectly omits the socialUri parameter, which should be extracted and passed to SIWXUtil.authConnectorAuthenticate, similar to its handling in the connect method.
packages/adapters/ethers/src/client.ts#L538-L551
appkit/packages/adapters/ethers/src/client.ts
Lines 538 to 551 in 7ed122a
packages/adapters/ethers5/src/client.ts#L590-L603
appkit/packages/adapters/ethers5/src/client.ts
Lines 590 to 603 in 7ed122a
Was this report helpful? Give feedback by reacting with 👍 or 👎
Description
Please include a brief summary of the change.
Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist