Conversation
🦋 Changeset detectedLatest commit: bf1d188 The changes in this PR will be included in the next version bump. This PR includes changesets to release 23 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
10 Skipped Deployments
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Bug: Incorrect Native Currency Symbol in Error Handling
When balance fetching fails, the native currency symbol is hardcoded to 'ETH' in the error fallback. This is inconsistent with successful fetches, which correctly use caipNetwork.nativeCurrency.symbol. Consequently, on non-Ethereum networks (e.g., Polygon, BSC), a failed balance fetch will incorrectly display 'ETH' instead of the actual native currency symbol (e.g., 'MATIC', 'BNB').
packages/adapters/ethers/src/client.ts#L695-L698
appkit/packages/adapters/ethers/src/client.ts
Lines 695 to 698 in bf1d188
packages/adapters/ethers5/src/client.ts#L702-L705
appkit/packages/adapters/ethers5/src/client.ts
Lines 702 to 705 in bf1d188
Was this report helpful? Give feedback by reacting with 👍 or 👎
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
tomiir
deleted the
enes/apkt-3158-balance-calls-blocking-the-appkit-initialization-if-fails
branch
4 participants
Description
Refactors Ethers and Ethers5 adapters to resolve the balance calls to not block the AppKit to be initialized. When there is an error thrown in the JsonRpcProvider's calls, it's blocking AppKit to proceed.
Example track trace:
Uncaught (in promise) Error: server response 400 (request={ }, response={ }, error=null, info={ "requestUrl": "https://rpc.walletconnect.org/v1/?chainId=eip155%3A10&projectId=PROJ_ID", "responseBody": "{\"id\":\"\",\"jsonrpc\":\"2.0\",\"error\":{\"code\":-32000,\"message\":\"invalid request: json: cannot unmarshal array into Go value of type jsonrpc.Request\",\"data\":{\"error\":\"json: cannot unmarshal array into Go value of type jsonrpc.Request\",\"retryable\":\"false\"}}}", "responseStatus": "400 " }, code=SERVER_ERROR, version=6.14.0) at makeError (errors.js:137:21) at assert (errors.js:156:15) at FetchResponse.assertOk (fetch.js:846:59) at JsonRpcProvider._send (provider-jsonrpc.js:935:18) at async eval (provider-jsonrpc.js:301:40)Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist