refactor: Valtio useSnapshot issue, laboratory Next.js 15 upgrade, Next Auth v5 transition#4607
Merged
enesozturk merged 37 commits intomainfrom Sep 1, 2025
Conversation
🦋 Changeset detectedLatest commit: 6b20180 The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
10 Skipped Deployments
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
enesozturk
changed the title
Contributor
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
enesozturk
commented
Aug 29, 2025
enesozturk
commented
Aug 29, 2025
enesozturk
commented
Aug 29, 2025
enesozturk
commented
Aug 29, 2025
enesozturk
commented
Aug 29, 2025
enesozturk
commented
Aug 29, 2025
0xmkh
reviewed
Aug 29, 2025
0xmkh
approved these changes
Aug 29, 2025
svenvoskamp
approved these changes
Aug 29, 2025
tomiir
approved these changes
Aug 29, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
enesozturk
commented
Sep 1, 2025
0xmkh
reviewed
Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes several key updates and improvements across the codebase:
useSnapshotusinguseSyncExternalStorethat fails on React v19.1.x. This issue was raised in Valtio Discussion #1115. The changes ensure compatibility with React versions <=19.0.0, preventing errors related to non-iterable proxyState.auth.tsto transition to Next Auth V5, enhancing security measures and aligning with the latest best practices.Refactor Verify tests
The
routeInterceptUrlfunction has been used for malicious URL tests - what it does is replacing the current URL of the laboratory example with the malicious URL, but fetch the laboratory URL on Playwright browser. With this way, it's going to mimic the malicious URL but the page itself will be AppKit lab. It's a hack to continue using laboratory test utils modalPage.connectUri(), modalPage.sign() etc. But since we recently switched to search parameters approach on laboratory app, with the Next.js 15 this approach doesn't work. (I've did many debugs and investigations but couldn't find the root cause.So what I did is the running the tests in our malicious URL directly instead: https://malicious-app-verify-simulation.vercel.app/
Updated ModalPage.ts and ModalValidator.ts to have separate utils:
connectUriMalicioussignMaliciousetc.So we don't need to make that trick any more bc that malicious app already using AppKit.
Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist