Skip to content

fix: unsyncing connection on initialization if enableReconnect is false#4610

Merged
enesozturk merged 10 commits intomainfrom
enes/apkt-3176-setting-enablereconnect-to-false-doesnt-remove-connection
Jul 7, 2025
Merged

fix: unsyncing connection on initialization if enableReconnect is false#4610
enesozturk merged 10 commits intomainfrom
enes/apkt-3176-setting-enablereconnect-to-false-doesnt-remove-connection

Conversation

@enesozturk
Copy link
Copy Markdown
Contributor

@enesozturk enesozturk commented Jul 4, 2025

Description

Fixes issue where the unSyncExistingConnection doesn't remove the connection from the wallet

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@vercel
Copy link
Copy Markdown

vercel bot commented Jul 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-basic-html ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2025 7:29pm
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2025 7:29pm
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2025 7:29pm
10 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-example ⬜️ Ignored (Inspect) Jul 7, 2025 7:29pm
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) Jul 7, 2025 7:29pm
appkit-basic-up-example ⬜️ Ignored (Inspect) Visit Preview Jul 7, 2025 7:29pm
appkit-ethers5-bera ⬜️ Ignored (Inspect) Jul 7, 2025 7:29pm
appkit-nansen-demo ⬜️ Ignored (Inspect) Jul 7, 2025 7:29pm
appkit-vue-solana ⬜️ Ignored (Inspect) Jul 7, 2025 7:29pm
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Jul 7, 2025 7:29pm
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) Jul 7, 2025 7:29pm
next-wagmi-solana-bitcoin-example ⬜️ Ignored (Inspect) Jul 7, 2025 7:29pm
vue-wagmi-example ⬜️ Ignored (Inspect) Jul 7, 2025 7:29pm

@linear
Copy link
Copy Markdown

linear bot commented Jul 4, 2025

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jul 4, 2025

🦋 Changeset detected

Latest commit: 1a5b60f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages
Name Type
@reown/appkit Patch
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-codemod Patch
@reown/appkit-common Patch
@reown/appkit-controllers Patch
@reown/appkit-core Patch
@reown/appkit-experimental Patch
@reown/appkit-pay Patch
@reown/appkit-polyfills Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-testing Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch
@reown/appkit-wallet-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 4, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 77.71% 30864 / 39715
🔵 Statements 77.71% 30864 / 39715
🔵 Functions 68.77% 2539 / 3692
🔵 Branches 84.25% 6411 / 7609
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/appkit/exports/constants.ts 100% 100% 100% 100%
packages/appkit/src/client/appkit-base-client.ts 72.79% 88.52% 75.79% 72.79% 183, 194-197, 210-236, 268-269, 271-272, 277-278, 357-358, 394-400, 465-466, 495-501, 504-505, 508-509, 527-528, 543-544, 547-548, 590-591, 594, 635-639, 646-647, 650-651, 662-685, 694-695, 712-724, 728-749, 752-758, 761-767, 770-776, 779-785, 788-798, 801-807, 810-816, 832-844, 850-883, 886-896, 948-949, 954, 969-985, 993, 997-1004, 1071-1073, 1079-1080, 1088-1089, 1091-1092, 1141-1150, 1185-1186, 1198-1199, 1204, 1227-1232, 1275, 1296-1297, 1307, 1309-1325, 1330, 1383-1394, 1436-1444, 1489, 1495-1499, 1518-1519, 1536-1539, 1575-1595, 1618-1629, 1658-1659, 1665-1691, 1899-1900, 1932-1933, 1936-1937, 1950-1953, 1956-1957, 1977-1978, 1981-1982, 1994-2004, 2022-2023, 2026-2032, 2036-2037, 2051, 2059, 2062, 2066, 2071-2090, 2093-2102, 2109-2110, 2124-2125, 2128-2129, 2136-2137, 2176-2177, 2260-2261, 2264-2265, 2268-2271, 2274-2275, 2278-2279, 2282-2283, 2286-2287, 2290-2294, 2303-2312, 2321-227, 1148, 1625, 2073-2094
Generated in workflow #13198 for commit 1a5b60f by the Vitest Coverage Report Action

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@enesozturk enesozturk requested a review from a team July 7, 2025 08:43
cursor[bot]

This comment was marked as outdated.

@enesozturk enesozturk enabled auto-merge July 7, 2025 19:29
@enesozturk enesozturk added this pull request to the merge queue Jul 7, 2025
Merged via the queue into main with commit 9c73366 Jul 7, 2025
40 checks passed
@enesozturk enesozturk deleted the enes/apkt-3176-setting-enablereconnect-to-false-doesnt-remove-connection branch July 7, 2025 19:56
@github-actions github-actions bot mentioned this pull request Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants