Skip to content

fix: approval transaction infinite loading#4625

Merged
tomiir merged 6 commits intomainfrom
fix/approval-tx-redirect
Jul 8, 2025
Merged

fix: approval transaction infinite loading#4625
tomiir merged 6 commits intomainfrom
fix/approval-tx-redirect

Conversation

@tomiir
Copy link
Copy Markdown
Collaborator

@tomiir tomiir commented Jul 8, 2025

Description

Fixes issue where approving an ERC20 spend with embedded wallet results in infinite spinner

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jul 8, 2025

🦋 Changeset detected

Latest commit: 36b770f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages
Name Type
@reown/appkit-controllers Patch
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-codemod Patch
@reown/appkit-common Patch
@reown/appkit-core Patch
@reown/appkit-experimental Patch
@reown/appkit-pay Patch
@reown/appkit-polyfills Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-testing Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch
@reown/appkit-wallet-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Jul 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-basic-html ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2025 8:43pm
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2025 8:43pm
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2025 8:43pm
10 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-example ⬜️ Ignored (Inspect) Jul 8, 2025 8:43pm
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) Jul 8, 2025 8:43pm
appkit-basic-up-example ⬜️ Ignored (Inspect) Visit Preview Jul 8, 2025 8:43pm
appkit-ethers5-bera ⬜️ Ignored (Inspect) Jul 8, 2025 8:43pm
appkit-nansen-demo ⬜️ Ignored (Inspect) Jul 8, 2025 8:43pm
appkit-vue-solana ⬜️ Ignored (Inspect) Jul 8, 2025 8:43pm
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Jul 8, 2025 8:43pm
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) Jul 8, 2025 8:43pm
next-wagmi-solana-bitcoin-example ⬜️ Ignored (Inspect) Jul 8, 2025 8:43pm
vue-wagmi-example ⬜️ Ignored (Inspect) Jul 8, 2025 8:43pm

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 8, 2025

Warnings
⚠️

🔑 Potential High‑entropy string detected in packages/controllers/tests/controllers/SwapController.test.ts (line 55): 0xeeeeeeeeeeeeeeeeee...

⚠️

🔑 Potential High‑entropy string detected in packages/controllers/tests/controllers/SwapController.test.ts (line 57): 0x2c89bbc92bd86f8075...

Generated by 🚫 dangerJS against 36b770f

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 8, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 77.79% 30684 / 39442
🔵 Statements 77.79% 30684 / 39442
🔵 Functions 68.8% 2528 / 3674
🔵 Branches 84.25% 6385 / 7578
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/controllers/src/controllers/SwapController.ts 54.9% 70.78% 68.33% 54.9% 55-58, 185, 195-196, 226-231, 264-266, 275-276, 284-298, 327, 336-337, 345-348, 381, 388, 393-410, 419-421, 435-436, 447-448, 460, 467-468, 472-480, 484, 486, 488, 490, 535-544, 579-609, 613-667, 671-725, 729-730, 745-746, 762-781, 785-867, 779-863
Generated in workflow #13232 for commit 36b770f by the Vitest Coverage Report Action

@tomiir tomiir added this pull request to the merge queue Jul 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 8, 2025
@tomiir tomiir merged commit a8212a7 into main Jul 8, 2025
57 of 58 checks passed
@tomiir tomiir deleted the fix/approval-tx-redirect branch July 8, 2025 21:32
@github-actions github-actions bot mentioned this pull request Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants