Skip to content

fix: remove call to connectSocial from connectionControllerUtil#4638

Merged
tomiir merged 39 commits intomainfrom
fix/wallet-button-twice
Jul 9, 2025
Merged

fix: remove call to connectSocial from connectionControllerUtil#4638
tomiir merged 39 commits intomainfrom
fix/wallet-button-twice

Conversation

@svenvoskamp
Copy link
Copy Markdown
Contributor

Description

fix: remove call to connectSocial from connectionControllerUtil

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

svenvoskamp added 30 commits May 6, 2025 09:33
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jul 9, 2025

🦋 Changeset detected

Latest commit: 7b86259

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages
Name Type
@reown/appkit-wallet-button Patch
@reown/appkit-controllers Patch
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit Patch
@reown/appkit-ui Patch
@reown/appkit-core Patch
@reown/appkit-utils Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-experimental Patch
@reown/appkit-pay Patch
@reown/appkit-cdn Patch
@reown/appkit-testing Patch
@reown/appkit-common Patch
@reown/appkit-polyfills Patch
@reown/appkit-wallet Patch
@reown/appkit-cli Patch
@reown/appkit-codemod Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Jul 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-basic-html ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2025 8:00am
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2025 8:00am
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2025 8:00am
10 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-example ⬜️ Ignored (Inspect) Jul 9, 2025 8:00am
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) Jul 9, 2025 8:00am
appkit-basic-up-example ⬜️ Ignored (Inspect) Jul 9, 2025 8:00am
appkit-ethers5-bera ⬜️ Ignored (Inspect) Jul 9, 2025 8:00am
appkit-nansen-demo ⬜️ Ignored (Inspect) Jul 9, 2025 8:00am
appkit-vue-solana ⬜️ Ignored (Inspect) Jul 9, 2025 8:00am
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Jul 9, 2025 8:00am
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) Jul 9, 2025 8:00am
next-wagmi-solana-bitcoin-example ⬜️ Ignored (Inspect) Jul 9, 2025 8:00am
vue-wagmi-example ⬜️ Ignored (Inspect) Jul 9, 2025 8:00am

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 9, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 77.78% 30698 / 39464
🔵 Statements 77.78% 30698 / 39464
🔵 Functions 68.8% 2528 / 3674
🔵 Branches 84.26% 6390 / 7583
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/controllers/src/utils/ConnectorControllerUtil.ts 18.68% 88.88% 33.33% 18.68% 73-74, 94-107, 110-280, 283-313, 316-356, 359-365, 181
packages/wallet-button/src/client.ts 61.03% 81.25% 36.36% 61.03% 36-37, 45-53, 59-60, 62-63, 71, 81-90, 92-93, 98-99
Generated in workflow #13277 for commit 7b86259 by the Vitest Coverage Report Action

@svenvoskamp svenvoskamp enabled auto-merge July 9, 2025 13:31
@svenvoskamp svenvoskamp added this pull request to the merge queue Jul 9, 2025
@tomiir tomiir removed this pull request from the merge queue due to a manual request Jul 9, 2025
@tomiir tomiir merged commit a083a94 into main Jul 9, 2025
41 of 45 checks passed
@tomiir tomiir deleted the fix/wallet-button-twice branch July 9, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants