Skip to content

chore: add activeCaipNetworkId to all events#4644

Merged
tomiir merged 10 commits intomainfrom
chore/caipNetworkId-in-events
Aug 5, 2025
Merged

chore: add activeCaipNetworkId to all events#4644
tomiir merged 10 commits intomainfrom
chore/caipNetworkId-in-events

Conversation

@tomiir
Copy link
Copy Markdown
Collaborator

@tomiir tomiir commented Jul 10, 2025

Description

  • Adds caipNetworkId to all events' properties

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jul 10, 2025

⚠️ No Changeset found

Latest commit: a7c10d6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Jul 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-basic-html ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2025 7:34am
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2025 7:34am
appkit-gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2025 7:34am
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2025 7:34am
10 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-example ⬜️ Ignored (Inspect) Aug 5, 2025 7:34am
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) Aug 5, 2025 7:34am
appkit-basic-up-example ⬜️ Ignored (Inspect) Aug 5, 2025 7:34am
appkit-ethers5-bera ⬜️ Ignored (Inspect) Aug 5, 2025 7:34am
appkit-nansen-demo ⬜️ Ignored (Inspect) Aug 5, 2025 7:34am
appkit-vue-solana ⬜️ Ignored (Inspect) Aug 5, 2025 7:34am
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Aug 5, 2025 7:34am
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) Aug 5, 2025 7:34am
next-wagmi-solana-bitcoin-example ⬜️ Ignored (Inspect) Aug 5, 2025 7:34am
vue-wagmi-example ⬜️ Ignored (Inspect) Aug 5, 2025 7:34am

@tomiir tomiir enabled auto-merge July 17, 2025 14:35
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing Network ID in SDK Error Event

The INTERNAL_SDK_ERROR event type definition is missing the caipNetworkId property. This creates a mismatch with the EventsController's runtime behavior, which will still add caipNetworkId to this event.

packages/controllers/src/utils/TypeUtil.ts#L500-L509

| {
type: 'error'
event: 'INTERNAL_SDK_ERROR'
properties: {
errorType?: string
errorMessage?: string
stackTrace?: string
uncaught?: boolean
}
}

Fix in CursorFix in Web


Was this report helpful? Give feedback by reacting with 👍 or 👎

Copy link
Copy Markdown

@dnul dnul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 5, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 77.71% 31886 / 41032
🔵 Statements 77.71% 31886 / 41032
🔵 Functions 69.52% 2642 / 3800
🔵 Branches 84.67% 6789 / 8018
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/appkit/exports/constants.ts 100% 100% 100% 100%
packages/appkit/src/client/appkit.ts 47.43% 78.43% 82.14% 47.43% 70-117, 120-134, 137-144, 147-163, 166-178, 183-193, 199-200, 225-226, 233-234, 247-270, 278-290, 292, 294-313, 315-329, 354-360, 376, 397-398, 403-404, 419-503, 543, 549-552, 574-575, 598-600, 608-609, 648-649, 652-653
packages/controllers/src/controllers/ConnectionController.ts 80.83% 80% 52.87% 80.83% 162, 217-221, 224-228, 257-261, 269-270, 277-296, 303, 311, 315, 319, 323, 327, 331, 335, 339, 370-371, 374-375, 411, 415, 449-451, 462-463, 498-499, 509-510, 512-513, 521-522, 524-525, 531-543, 384
packages/controllers/src/controllers/EventsController.ts 97.64% 97.05% 85.71% 97.64% 58-59
packages/controllers/src/utils/ConnectorControllerUtil.ts 22.52% 64.28% 46.66% 22.52% 75-76, 96-109, 112-284, 287-317, 324-325, 328-329, 341-363, 366-372, 185
packages/scaffold-ui/src/partials/w3m-account-default-widget/index.ts 80.6% 83.33% 65% 80.6% 73-74, 83, 87-89, 152, 158-159, 180, 203-204, 242, 250-251, 269, 276-277, 299, 303-304, 307-308, 311-312, 327, 331-341, 355-357, 379-381, 384-385, 338
packages/scaffold-ui/src/partials/w3m-connecting-wc-browser/index.ts 92.59% 58.33% 75% 92.59% 17-18, 41-42
packages/scaffold-ui/src/views/w3m-account-settings-view/index.ts 13.65% 100% 0% 13.65% 59-79, 82-83, 87-157, 161-188, 191-212, 215-220, 223-231, 234-268, 271-272, 275-300, 303-306, 309-333, 336-338
packages/scaffold-ui/src/views/w3m-connecting-external-view/index.ts 74.4% 68.18% 71.42% 74.4% 33-34, 58-68, 75-76, 94-104, 107-113, 164, 102
packages/scaffold-ui/src/views/w3m-connecting-farcaster-view/index.ts 75.56% 92.3% 66.66% 75.56% 59-62, 65-67, 70, 79-82, 94-95, 121, 154, 158-187, 244-256, 281, 295, 304-312
packages/scaffold-ui/src/views/w3m-connecting-social-view/index.ts 81.43% 64.7% 62.5% 81.43% 65-68, 74-75, 77-78, 81, 142, 220-232, 238-245
packages/scaffold-ui/src/views/w3m-email-verify-otp-view/index.ts 74.54% 75% 50% 74.54% 34-35, 67-73, 77-81
packages/scaffold-ui/src/views/w3m-unsupported-chain-view/index.ts 68.86% 81.25% 70% 68.86% 49, 91, 97-103, 109, 122-123, 130-135, 168-188, 124
Generated in workflow #13990 for commit a7c10d6 by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants