Skip to content

chore: upgrade storybook, remove unused comps, add missing stories#4651

Merged
tomiir merged 2 commits intomainfrom
chore/storybook-missing-comps-and-upgrade
Jul 14, 2025
Merged

chore: upgrade storybook, remove unused comps, add missing stories#4651
tomiir merged 2 commits intomainfrom
chore/storybook-missing-comps-and-upgrade

Conversation

@enesozturk
Copy link
Copy Markdown
Contributor

@enesozturk enesozturk commented Jul 14, 2025

Description

  • Upgrades Storybook as current version is not compatibly with repo's React version
  • Removes redundant component files and exports
  • Adds missing component stories

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@vercel
Copy link
Copy Markdown

vercel bot commented Jul 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-basic-html ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2025 2:36pm
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2025 2:36pm
appkit-gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2025 2:36pm
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2025 2:36pm
10 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-example ⬜️ Ignored (Inspect) Jul 14, 2025 2:36pm
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) Jul 14, 2025 2:36pm
appkit-basic-up-example ⬜️ Ignored (Inspect) Visit Preview Jul 14, 2025 2:36pm
appkit-ethers5-bera ⬜️ Ignored (Inspect) Jul 14, 2025 2:36pm
appkit-nansen-demo ⬜️ Ignored (Inspect) Jul 14, 2025 2:36pm
appkit-vue-solana ⬜️ Ignored (Inspect) Jul 14, 2025 2:36pm
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Jul 14, 2025 2:36pm
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) Jul 14, 2025 2:36pm
next-wagmi-solana-bitcoin-example ⬜️ Ignored (Inspect) Jul 14, 2025 2:36pm
vue-wagmi-example ⬜️ Ignored (Inspect) Jul 14, 2025 2:36pm

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jul 14, 2025

⚠️ No Changeset found

Latest commit: ef18700

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@enesozturk enesozturk requested review from svenvoskamp and tomiir and removed request for svenvoskamp July 14, 2025 14:25
cursor[bot]

This comment was marked as outdated.

@socket-security
Copy link
Copy Markdown

socket-security bot commented Jul 14, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedreact@​19.1.01001008397100
Added@​chromatic-com/​storybook@​3.2.79810090100100

View full report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 14, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 77.64% 30770 / 39629
🔵 Statements 77.64% 30770 / 39629
🔵 Functions 68.88% 2530 / 3673
🔵 Branches 84.18% 6416 / 7621
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/scaffold-ui/src/partials/w3m-account-default-widget/index.ts 80.26% 83.33% 65% 80.26% 73-74, 83, 87-89, 152, 158-159, 180, 203-204, 242, 250-251, 269, 276-277, 299, 303-304, 307-308, 311-312, 327, 331-341, 355-357, 375-377, 380-381, 338
Generated in workflow #13330 for commit ef18700 by the Vitest Coverage Report Action

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Temporary File Incorrectly Committed

The Storybook story file wui-ux-by-reown.stories copy.ts was accidentally committed. The "copy" suffix indicates it's a temporary or duplicate file that should not be present in the codebase.

apps/gallery/stories/composites/wui-ux-by-reown.stories copy.ts#L1-L17

https://github.com/reown-com/appkit/blob/ef187007dbe34c3d217967a37a6889e94564d426/apps/gallery/stories/composites/wui-ux-by-reown.stories copy.ts#L1-L17

Fix in CursorFix in Web


Was this report helpful? Give feedback by reacting with 👍 or 👎

@enesozturk enesozturk enabled auto-merge July 14, 2025 14:46
@enesozturk enesozturk added this pull request to the merge queue Jul 14, 2025
@tomiir tomiir removed this pull request from the merge queue due to a manual request Jul 14, 2025
@tomiir tomiir merged commit 2677811 into main Jul 14, 2025
59 of 60 checks passed
@tomiir tomiir deleted the chore/storybook-missing-comps-and-upgrade branch July 14, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants