Skip to content

fix: SIWX default cross-namespace switch with embedded wallet#4657

Merged
tomiir merged 13 commits intomainfrom
fix/siwx-default
Jul 16, 2025
Merged

fix: SIWX default cross-namespace switch with embedded wallet#4657
tomiir merged 13 commits intomainfrom
fix/siwx-default

Conversation

@tomiir
Copy link
Copy Markdown
Collaborator

@tomiir tomiir commented Jul 14, 2025

Description

  • Fixes issue with SIWX where switching from evm to solana would cause an infinite loading.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

Closes APKT-3320

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@linear
Copy link
Copy Markdown

linear bot commented Jul 14, 2025

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jul 14, 2025

🦋 Changeset detected

Latest commit: ca06aa1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages
Name Type
@reown/appkit-controllers Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit Patch
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit-ui Patch
@reown/appkit-core Patch
@reown/appkit-utils Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-wallet-button Patch
@reown/appkit-experimental Patch
@reown/appkit-pay Patch
@reown/appkit-cdn Patch
@reown/appkit-testing Patch
@reown/appkit-common Patch
@reown/appkit-polyfills Patch
@reown/appkit-wallet Patch
@reown/appkit-cli Patch
@reown/appkit-codemod Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Jul 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-basic-html ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2025 3:07pm
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2025 3:07pm
appkit-gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2025 3:07pm
appkit-laboratory 🛑 Canceled (Inspect) 💬 Add feedback Jul 15, 2025 3:07pm
10 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-example ⬜️ Ignored (Inspect) Jul 15, 2025 3:07pm
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) Jul 15, 2025 3:07pm
appkit-basic-up-example ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2025 3:07pm
appkit-ethers5-bera ⬜️ Ignored (Inspect) Jul 15, 2025 3:07pm
appkit-nansen-demo ⬜️ Ignored (Inspect) Jul 15, 2025 3:07pm
appkit-vue-solana ⬜️ Ignored (Inspect) Jul 15, 2025 3:07pm
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Jul 15, 2025 3:07pm
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) Jul 15, 2025 3:07pm
next-wagmi-solana-bitcoin-example ⬜️ Ignored (Inspect) Jul 15, 2025 3:07pm
vue-wagmi-example ⬜️ Ignored (Inspect) Jul 15, 2025 3:07pm

cursor[bot]

This comment was marked as outdated.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 14, 2025

Warnings
⚠️ Changes were made to one or more package.json(s), but not to pnpm-lock.yaml

Generated by 🚫 dangerJS against ca06aa1

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 14, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 77.64% 30787 / 39652
🔵 Statements 77.64% 30787 / 39652
🔵 Functions 68.85% 2531 / 3676
🔵 Branches 84.27% 6428 / 7627
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/appkit/exports/constants.ts 100% 100% 100% 100%
packages/controllers/src/controllers/ChainController.ts 78.76% 88.34% 74.72% 78.76% 179-190, 194-213, 217-227, 231-253, 275-276, 297-298, 386-393, 397-410, 417-418, 437-438, 452-453, 458-459, 462-463, 472-473, 478-479, 495-496, 514-515, 537-540, 561-568, 615-621, 634-635, 669-670, 723, 749-750, 789-790, 101, 197, 747
packages/controllers/src/utils/SIWXUtil.ts 76.69% 70.58% 56.52% 76.69% 40-41, 45-46, 51-52, 58-71, 80-81, 84-85, 88-89, 92-93, 105-106, 141, 163-164, 166-167, 177-179, 182-197, 269, 314-338, 425-436, 448-449, 317-344
packages/scaffold-ui/src/modal/w3m-account-button/index.ts 81.61% 83.87% 83.33% 81.61% 72-73, 79-84, 91, 94, 101-106, 117-118, 149, 163-164, 169-170, 184-185
packages/scaffold-ui/src/modal/w3m-modal/index.ts 89.33% 94.11% 100% 89.33% 73-76, 91-92, 114, 118, 145, 190, 208-216, 310-311, 320-322
packages/scaffold-ui/src/views/w3m-network-switch-view/index.ts 21.51% 100% 0% 21.51% 38-39, 42-43, 46-47, 51-103, 107-116, 119-126, 129-137, 140-151
Generated in workflow #13384 for commit ca06aa1 by the Vitest Coverage Report Action

cursor[bot]

This comment was marked as outdated.

@socket-security
Copy link
Copy Markdown

socket-security bot commented Jul 15, 2025

@cursor
Copy link
Copy Markdown

cursor bot commented Jul 15, 2025

🚨 BugBot couldn't run

Something went wrong. Try again by commenting "bugbot run", or contact support (requestId: serverGenReqId_e90e096b-337b-4ba5-833e-e7a12a3de363).

@tomiir tomiir merged commit 7788000 into main Jul 16, 2025
41 checks passed
@tomiir tomiir deleted the fix/siwx-default branch July 16, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants