Skip to content

chore: deprecate solana wallets parameter#4670

Merged
tomiir merged 3 commits intomainfrom
chore/deprecate-solana-wallets
Jul 17, 2025
Merged

chore: deprecate solana wallets parameter#4670
tomiir merged 3 commits intomainfrom
chore/deprecate-solana-wallets

Conversation

@tomiir
Copy link
Copy Markdown
Collaborator

@tomiir tomiir commented Jul 17, 2025

Description

  • Deprecates unused Solana adapter wallets parameter as it is misleading.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jul 17, 2025

🦋 Changeset detected

Latest commit: 2aecf8c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages
Name Type
@reown/appkit-adapter-solana Patch
@reown/appkit-cdn Patch
@reown/appkit Patch
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit-common Patch
@reown/appkit-ui Patch
@reown/appkit-controllers Patch
@reown/appkit-core Patch
@reown/appkit-utils Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-polyfills Patch
@reown/appkit-wallet Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-wallet-button Patch
@reown/appkit-experimental Patch
@reown/appkit-testing Patch
@reown/appkit-cli Patch
@reown/appkit-pay Patch
@reown/appkit-codemod Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Jul 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-basic-html ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2025 8:32pm
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2025 8:32pm
appkit-gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2025 8:32pm
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2025 8:32pm
10 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-example ⬜️ Ignored (Inspect) Jul 17, 2025 8:32pm
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) Jul 17, 2025 8:32pm
appkit-basic-up-example ⬜️ Ignored (Inspect) Jul 17, 2025 8:32pm
appkit-ethers5-bera ⬜️ Ignored (Inspect) Jul 17, 2025 8:32pm
appkit-nansen-demo ⬜️ Ignored (Inspect) Jul 17, 2025 8:32pm
appkit-vue-solana ⬜️ Ignored (Inspect) Jul 17, 2025 8:32pm
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Jul 17, 2025 8:32pm
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) Jul 17, 2025 8:32pm
next-wagmi-solana-bitcoin-example ⬜️ Ignored (Inspect) Jul 17, 2025 8:32pm
vue-wagmi-example ⬜️ Ignored (Inspect) Jul 17, 2025 8:32pm

@socket-security
Copy link
Copy Markdown

socket-security bot commented Jul 17, 2025

@tomiir tomiir changed the title Chore/deprecate solana wallets parameter chore: deprecate solana wallets parameter Jul 17, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 17, 2025

Warnings
⚠️

🔑 Potential High‑entropy string detected in packages/adapters/solana/src/client.ts (line 182): 11111111111111111111...

⚠️

🔑 Potential High‑entropy string detected in examples/react-solana/src/config.ts (line 16): b56e18d47c72ab683b10...

⚠️

🔑 Potential High‑entropy string detected in examples/vue-wagmi-solana/src/config.ts (line 13): b56e18d47c72ab683b10...

⚠️

🔑 Potential High‑entropy string detected in examples/html-wagmi-cdn/src/main.js (line 9): b56e18d47c72ab683b10...

Generated by 🚫 dangerJS against 2aecf8c

@github-actions
Copy link
Copy Markdown
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 77.65% 30822 / 39693
🔵 Statements 77.65% 30822 / 39693
🔵 Functions 68.87% 2534 / 3679
🔵 Branches 84.27% 6431 / 7631
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/adapters/solana/src/client.ts 66.01% 75.71% 38.88% 66.01% 81-88, 92-93, 121-124, 127-128, 131-132, 135-136, 139-142, 145-153, 160-161, 171-191, 194-235, 238-239, 242-243, 251-252, 257-264, 284-297, 320-323, 347-348, 358-359, 378-379, 386-387, 411-412, 416-417, 420-421, 458-462, 486-487, 510-516
Generated in workflow #13476 for commit 2aecf8c by the Vitest Coverage Report Action

@tomiir tomiir merged commit dfc583c into main Jul 17, 2025
59 of 60 checks passed
@tomiir tomiir deleted the chore/deprecate-solana-wallets branch July 17, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants