Skip to content

chore: add branch name to artifacts#4673

Merged
enesozturk merged 10 commits intomainfrom
chore/add-branch-name-to-artifacts
Jul 19, 2025
Merged

chore: add branch name to artifacts#4673
enesozturk merged 10 commits intomainfrom
chore/add-branch-name-to-artifacts

Conversation

@enesozturk
Copy link
Copy Markdown
Contributor

@enesozturk enesozturk commented Jul 18, 2025

Description

To run the backwards compatibility tests on secure site, we are going to call AppKit's ui_tests.yml workflow with different branches. To be able to run this workflow from SS's workflow multiple time with different branches, it's required to make sure the artifacts' file names are unique by branch. This PR makes changes to ui_tests.yml to name the artifacts depending on the branch.

*Since the artifact names are file names, it cannot accept slashes, so we do replace slashes with underscore and use this value in the names using env variables.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jul 18, 2025

⚠️ No Changeset found

Latest commit: 4316756

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-basic-html ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2025 11:25pm
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2025 11:25pm
appkit-gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2025 11:25pm
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2025 11:25pm
10 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-example ⬜️ Ignored (Inspect) Jul 18, 2025 11:25pm
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) Jul 18, 2025 11:25pm
appkit-basic-up-example ⬜️ Ignored (Inspect) Jul 18, 2025 11:25pm
appkit-ethers5-bera ⬜️ Ignored (Inspect) Jul 18, 2025 11:25pm
appkit-nansen-demo ⬜️ Ignored (Inspect) Jul 18, 2025 11:25pm
appkit-vue-solana ⬜️ Ignored (Inspect) Jul 18, 2025 11:25pm
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Jul 18, 2025 11:25pm
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) Jul 18, 2025 11:25pm
next-wagmi-solana-bitcoin-example ⬜️ Ignored (Inspect) Jul 18, 2025 11:25pm
vue-wagmi-example ⬜️ Ignored (Inspect) Jul 18, 2025 11:25pm

cursor[bot]

This comment was marked as outdated.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 18, 2025

Warnings
⚠️

Workflow file .github/workflows/ui_tests.yml has been modified

Generated by 🚫 dangerJS against 4316756

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 18, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 77.63% 30819 / 39699
🔵 Statements 77.63% 30819 / 39699
🔵 Functions 68.87% 2534 / 3679
🔵 Branches 84.28% 6430 / 7629
File CoverageNo changed files found.
Generated in workflow #13506 for commit 4316756 by the Vitest Coverage Report Action

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@enesozturk enesozturk enabled auto-merge July 18, 2025 23:23
@enesozturk enesozturk added this pull request to the merge queue Jul 18, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 18, 2025
@enesozturk enesozturk added this pull request to the merge queue Jul 18, 2025
Merged via the queue into main with commit 84906fc Jul 19, 2025
41 checks passed
@enesozturk enesozturk deleted the chore/add-branch-name-to-artifacts branch July 19, 2025 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants