Skip to content

refactor: error messages#4686

Merged
enesozturk merged 7 commits intomainfrom
enes/apkt-3098-improve-error-handling
Jul 22, 2025
Merged

refactor: error messages#4686
enesozturk merged 7 commits intomainfrom
enes/apkt-3098-improve-error-handling

Conversation

@enesozturk
Copy link
Copy Markdown
Contributor

@enesozturk enesozturk commented Jul 22, 2025 •
edited
Loading

Description

Updates ErrorUtil to make sure each error has error code and updated the error messages.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@linear
Copy link
Copy Markdown

linear bot commented Jul 22, 2025

APKT-3098 Improve Error Handling

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jul 22, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 487bbf0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages
Name Type
@reown/appkit-utils Patch
@reown/appkit-controllers Patch
@reown/appkit Patch
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-codemod Patch
@reown/appkit-common Patch
@reown/appkit-core Patch
@reown/appkit-experimental Patch
@reown/appkit-pay Patch
@reown/appkit-polyfills Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-testing Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch
@reown/appkit-wallet-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Jul 22, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-basic-html ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2025 1:28pm
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2025 1:28pm
appkit-gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2025 1:28pm
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2025 1:28pm
10 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-example ⬜️ Ignored (Inspect) Jul 22, 2025 1:28pm
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) Jul 22, 2025 1:28pm
appkit-basic-up-example ⬜️ Ignored (Inspect) Jul 22, 2025 1:28pm
appkit-ethers5-bera ⬜️ Ignored (Inspect) Jul 22, 2025 1:28pm
appkit-nansen-demo ⬜️ Ignored (Inspect) Jul 22, 2025 1:28pm
appkit-vue-solana ⬜️ Ignored (Inspect) Jul 22, 2025 1:28pm
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Jul 22, 2025 1:28pm
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) Jul 22, 2025 1:28pm
next-wagmi-solana-bitcoin-example ⬜️ Ignored (Inspect) Jul 22, 2025 1:28pm
vue-wagmi-example ⬜️ Ignored (Inspect) Jul 22, 2025 1:28pm

@enesozturk enesozturk requested a review from a team July 22, 2025 07:52
cursor[bot]

This comment was marked as outdated.

Sign in to view

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 22, 2025 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 77.65% 30891 / 39778
🔵 Statements 77.65% 30891 / 39778
🔵 Functions 68.87% 2538 / 3685
🔵 Branches 84.32% 6454 / 7654
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/appkit-utils/src/ErrorUtil.ts 96.34% 75% 50% 96.34% 42, 48, 54
packages/appkit/exports/constants.ts 100% 100% 100% 100%
packages/appkit/src/client/appkit-base-client.ts 72.54% 88.72% 75.79% 72.54% 183, 194-197, 207-208, 210-236, 268-269, 271-272, 277-278, 357-358, 394-400, 465-466, 495-501, 504-505, 508-509, 527-528, 543-544, 547-548, 590-591, 594, 635-639, 646-647, 650-651, 662-685, 694-695, 712-724, 728-749, 752-758, 761-767, 770-776, 779-785, 788-798, 801-807, 810-816, 832-844, 850-883, 886-896, 948-949, 954, 969-985, 993, 997-1004, 1071-1073, 1079-1080, 1088-1089, 1091-1092, 1141-1150, 1185-1186, 1198-1199, 1204, 1227-1232, 1275, 1296-1297, 1307, 1309-1325, 1330, 1383-1394, 1440-1453, 1498, 1504-1508, 1527-1528, 1545-1548, 1584-1604, 1627-1638, 1667-1668, 1674-1700, 1908-1909, 1941-1942, 1945-1946, 1959-1962, 1965-1966, 1986-1987, 1990-1991, 2003-2013, 2031-2032, 2035-2041, 2045-2046, 2060, 2068, 2071, 2075, 2080-2099, 2102-2111, 2118-2119, 2133-2134, 2137-2138, 2145-2146, 2185-2186, 2269-2270, 2273-2274, 2277-2280, 2283-2284, 2287-2288, 2291-2292, 2295-2296, 2299-2303, 2312-2321, 2330-227, 1148, 1634, 2082-2103
packages/appkit/src/utils/ConfigUtil.ts 94.65% 89.1% 87.5% 94.65% 36-37, 58-59, 85-86, 99, 110-111, 124, 154, 203-204
packages/common/src/utils/ConstantsUtil.ts 100% 0% 100% 100%
packages/controllers/src/controllers/AlertController.ts 100% 100% 80% 100%
packages/controllers/src/controllers/EventsController.ts 100% 100% 85.71% 100%
packages/controllers/src/controllers/SwapController.ts 54.9% 70.78% 68.33% 54.9% 55-58, 185, 195-196, 226-231, 264-266, 275-276, 284-298, 327, 336-337, 345-348, 381, 388, 393-410, 419-421, 435-436, 447-448, 460, 467-468, 472-480, 484, 486, 488, 490, 535-544, 579-609, 613-667, 671-725, 729-730, 745-746, 762-781, 785-867, 779-863
packages/scaffold-ui/src/partials/w3m-social-login-list/index.ts 78.48% 73.33% 75% 78.48% 43-44, 56-57, 67-68, 71-72, 85, 87, 105-111
packages/scaffold-ui/src/partials/w3m-social-login-widget/index.ts 59.76% 70.96% 84.61% 59.76% 54-55, 81, 90-93, 96-97, 110, 115, 117, 130, 139-140, 143-144, 151-193, 198-199, 211-218, 233-239
Generated in workflow #13571 for commit 487bbf0 by the Vitest Coverage Report Action

@enesozturk enesozturk enabled auto-merge July 22, 2025 10:35
cursor[bot]

This comment was marked as outdated.

Sign in to view

@enesozturk enesozturk force-pushed the enes/apkt-3098-improve-error-handling branch from cc6af2b to 568ba0d Compare July 22, 2025 10:50
cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

@svenvoskamp
Copy link
Copy Markdown
Contributor

svenvoskamp commented Jul 22, 2025

Do we even need to open AlertController for the remote config?

@enesozturk
Copy link
Copy Markdown
Contributor Author

enesozturk commented Jul 22, 2025

Do we even need to open AlertController for the remote config?

When we don't pass displayMessage (fka shortMessage), we only do console log, I think we could keep this use case where AlertController is not only for w3m-alert, also for just logs, wdyt?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 22, 2025

Warnings
⚠️

🔑 Potential High‑entropy string detected in packages/common/src/utils/ConstantsUtil.ts (line 52): 0xdac17f958d2ee523a2...
⚠️

🔑 Potential High‑entropy string detected in packages/common/src/utils/ConstantsUtil.ts (line 54): 0xc2132d05d31c914a87...
⚠️

🔑 Potential High‑entropy string detected in packages/common/src/utils/ConstantsUtil.ts (line 56): 0x9702230a8ea53601f5...
⚠️

🔑 Potential High‑entropy string detected in packages/common/src/utils/ConstantsUtil.ts (line 58): 0x919C1c267BC06a7039...
⚠️

🔑 Potential High‑entropy string detected in packages/common/src/utils/ConstantsUtil.ts (line 60): 0x48065fbBE25f71C928...
⚠️

🔑 Potential High‑entropy string detected in packages/common/src/utils/ConstantsUtil.ts (line 62): 0x55d398326f99059fF7...
⚠️

🔑 Potential High‑entropy string detected in packages/common/src/utils/ConstantsUtil.ts (line 64): 0xfd086bc7cd5c481dcc...

Generated by 🚫 dangerJS against 487bbf0

@enesozturk enesozturk added this pull request to the merge queue Jul 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 22, 2025
@enesozturk enesozturk added this pull request to the merge queue Jul 22, 2025
Merged via the queue into main with commit 2a953de Jul 22, 2025
41 checks passed
@enesozturk enesozturk deleted the enes/apkt-3098-improve-error-handling branch July 22, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@arein arein arein approved these changes

@tomiir tomiir tomiir approved these changes

@lukaisailovic lukaisailovic lukaisailovic approved these changes

@svenvoskamp svenvoskamp svenvoskamp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@enesozturk @svenvoskamp @arein @tomiir @lukaisailovic