fix: add support for Bitcoin test net in OKX Wallet #4691
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
10 Skipped Deployments
|
|
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Bug: Network Switch Fails, Connector State Corrupted
The OKXConnector.switchNetwork method introduces a state inconsistency. It unbinds events and replaces the wallet instance before attempting to connect to the new network. If the subsequent connect() call fails, the connector is left with the new, unconnected wallet, without event bindings, and the original working wallet state is unrecoverable, rendering the connector unusable.
packages/adapters/bitcoin/src/connectors/OKXConnector.ts#L123-L143
appkit/packages/adapters/bitcoin/src/connectors/OKXConnector.ts
Lines 123 to 143 in 5451345
Bug: OKX Connector Filters Out Bitcoin Testnet Chains
The chains getter in the OKX connector incorrectly filters supported networks, returning only Bitcoin mainnet chains. It should include Bitcoin Testnet chains, as the connector now supports both networks and uses the OKX_NETWORK_KEYS mapping for network identification.
packages/adapters/bitcoin/src/connectors/OKXConnector.ts#L42-L46
appkit/packages/adapters/bitcoin/src/connectors/OKXConnector.ts
Lines 42 to 46 in 5451345
Was this report helpful? Give feedback by reacting with 👍 or 👎
Description
add support for Bitcoin test net in OKX Wallet
Type of change
Associated Issues
For Linear issues: Closes APKT-3270
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist