fix: add support for okx testnet on initial connection#4693
fix: add support for okx testnet on initial connection#4693svenvoskamp merged 48 commits intomainfrom
Conversation
|
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Bug: Active Network Undefined Breaks Chain Filtering
The chains getter in OKXConnector now filters by this.getActiveNetwork()?.caipNetworkId. If getActiveNetwork() returns undefined, the getter returns an empty array because chain.caipNetworkId === undefined is always false. This breaks connection logic that expects at least one chain (e.g., connector.chains[0]), causing failures during initialization or when no active network is set. This is a breaking change from the previous behavior, which always returned Bitcoin mainnet chains.
packages/adapters/bitcoin/src/connectors/OKXConnector.ts#L49-L52
appkit/packages/adapters/bitcoin/src/connectors/OKXConnector.ts
Lines 49 to 52 in ebd8473
Was this report helpful? Give feedback by reacting with 👍 or 👎
Description
fix: add support for okx testnet on initial connection
Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist