Skip to content

chore: fix artifact name conflict#4697

Merged
enesozturk merged 3 commits intomainfrom
chore/artifact-name-fix
Jul 23, 2025
Merged

chore: fix artifact name conflict#4697
enesozturk merged 3 commits intomainfrom
chore/artifact-name-fix

Conversation

@enesozturk
Copy link
Copy Markdown
Contributor

@enesozturk enesozturk commented Jul 23, 2025

Description

Adds branch name to some artifacts to not confuse the secure site backwards compatible tests

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@vercel
Copy link
Copy Markdown

vercel bot commented Jul 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-basic-html ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2025 1:34pm
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2025 1:34pm
appkit-gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2025 1:34pm
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2025 1:34pm
10 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-example ⬜️ Ignored (Inspect) Jul 23, 2025 1:34pm
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) Jul 23, 2025 1:34pm
appkit-basic-up-example ⬜️ Ignored (Inspect) Jul 23, 2025 1:34pm
appkit-ethers5-bera ⬜️ Ignored (Inspect) Jul 23, 2025 1:34pm
appkit-nansen-demo ⬜️ Ignored (Inspect) Jul 23, 2025 1:34pm
appkit-vue-solana ⬜️ Ignored (Inspect) Jul 23, 2025 1:34pm
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Jul 23, 2025 1:34pm
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) Jul 23, 2025 1:34pm
next-wagmi-solana-bitcoin-example ⬜️ Ignored (Inspect) Jul 23, 2025 1:34pm
vue-wagmi-example ⬜️ Ignored (Inspect) Jul 23, 2025 1:34pm

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jul 23, 2025

⚠️ No Changeset found

Latest commit: ab04210

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 23, 2025

Warnings
⚠️

Workflow file .github/workflows/ui_tests.yml has been modified

Generated by 🚫 dangerJS against ab04210

cursor[bot]

This comment was marked as outdated.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 23, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 77.61% 31428 / 40493
🔵 Statements 77.61% 31428 / 40493
🔵 Functions 68.92% 2589 / 3756
🔵 Branches 84.46% 6633 / 7853
File CoverageNo changed files found.
Generated in workflow #13651 for commit ab04210 by the Vitest Coverage Report Action

cursor[bot]

This comment was marked as outdated.

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing Blob Upload Breaks Secure Site Tests

The removal of the "Upload Playwright Blob Report for Secure Site tests" step breaks workflows for secure-appkit repositories. This step was essential for secure-appkit as it specifically uploaded a single report.zip (not sharded) as playwright-blob-artifact-shard-all. Without it, secure-appkit workflows fail to upload the correct blob reports, causing the merge_reports job to fail when attempting to download artifacts that are either missing or in an unexpected format.

.github/workflows/ui_tests.yml#L379-L387

- name: Verify Cache Dir Exists Before Post Job
run: |
echo "Checking cache directory just before post-job phase:"
ls -la /tmp/playwright_cache # Use workspace path
continue-on-error: true # Don't fail the job if ls fails
merge_reports:
needs: ui_tests # Ensures this job runs only after all 'test' (sharded) jobs complete

Fix in CursorFix in Web


Was this report helpful? Give feedback by reacting with 👍 or 👎

@enesozturk enesozturk added this pull request to the merge queue Jul 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 23, 2025
@enesozturk enesozturk added this pull request to the merge queue Jul 23, 2025
Merged via the queue into main with commit d80b227 Jul 23, 2025
41 checks passed
@enesozturk enesozturk deleted the chore/artifact-name-fix branch July 23, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants